[3.7] bpo-35082: Don't report deleted attributes in __dir__ (GH-10148)#13859
Merged
Merged
Conversation
When an attribute is deleted from a Mock, a sentinel is added rather than just deleting the attribute. This commit checks for such sentinels when returning the child mocks in the __dir__ method as users won't expect deleted attributes to appear when performing dir(mock). (cherry picked from commit 0df635c) Co-authored-by: Mario Corchero <mariocj89@gmail.com>
Contributor
Author
|
@mariocj89 and @cjw296: Status check is done, and it's a failure ❌ . |
Contributor
Author
|
@mariocj89 and @cjw296: Status check is done, and it's a success ✅ . |
1 similar comment
Contributor
Author
|
@mariocj89 and @cjw296: Status check is done, and it's a success ✅ . |
asvetlov
approved these changes
Jun 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an attribute is deleted from a Mock, a sentinel is added rather
than just deleting the attribute. This commit checks for such sentinels
when returning the child mocks in the dir method as users won't
expect deleted attributes to appear when performing dir(mock).
(cherry picked from commit 0df635c)
Co-authored-by: Mario Corchero mariocj89@gmail.com
https://bugs.python.org/issue35082