Skip to content

gh-121190: A better error message from importlib.resources.files() when module spec is None #138531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
whitphx wants to merge 9 commits into from
+23 −3
Closed

gh-121190: A better error message from importlib.resources.files() when module spec is None #138531

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
078c801
Raise an exception with a better message from importlib.resources.fil…
whitphx Sep 5, 2025
c79a7cc
📜🤖 Added by blurb_it.
blurb-it[bot] Sep 5, 2025
5ed2652
Fix Blurb
whitphx Sep 5, 2025
847d8df
Remove type annotations
whitphx Sep 6, 2025
e25491e
Modify the error message
whitphx Sep 7, 2025
06b8233
Merge branch 'main' into gh-121190
whitphx Sep 10, 2025
7dc7e46
Revert a change removing the default adapter argument on SpecLoaderAd…
whitphx Sep 19, 2025
9e98cfc
Apply suggestion from @danielhollas
whitphx Oct 22, 2025
d3ec82a
fix the error message
whitphx Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix the error message
  • Loading branch information
@whitphx
whitphx committed Oct 22, 2025
commit d3ec82a71c119e3eda2f2ea81a2af4a734c4785c
4 changes: 2 additions & 2 deletions Lib/importlib/resources/_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,8 @@ def from_package(package: types.ModuleType):

if package.__spec__ is None:
raise TypeError(
f"Cannot access resources for '{package.__name__}' "
"as it does not correspond to an importable module."
f"Cannot access resources for '{package.__name__ or package!r}' "
"as it does not appear to correspond to an importable module (its __spec__ is None)."
)

spec = wrap_spec(package.__spec__)
Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_importlib/resources/test_resource.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ def test_main_module_with_none_spec(self):

self.assertIsNone(mainmodule.__spec__)

with self.assertRaises(TypeError):
with self.assertRaises(TypeError, msg="Cannot access resources for '__main__' as it does not appear to correspond to an importable module (its __spec__ is None)."):
resources.files(mainmodule)


Expand Down
Loading