-
-
Notifications
You must be signed in to change notification settings - Fork 34.5k
gh-138171: Migrate iOS testbed location and add Apple build script #138176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
4a11615
b89f46f
68d671b
39856d1
f6a836c
c692e9a
fe39aa4
ceff927
2208323
e856075
2606b8f
2114dd5
d56a3de
611d82b
4feeabe
ebbbf32
e0f6b5a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- Loading branch information
There are no files selected for viewing
|
hugovk marked this conversation as resolved.
|
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -798,10 +798,15 @@ def test(context: argparse.Namespace, host: str | None = None) -> None: | |
| + [ | ||
| "--", | ||
| "test", | ||
| "-uall", | ||
| "--slow-ci" if context.slow else "--fast-ci", | ||
| "--single-process", | ||
| "--rerun", | ||
| "-W", | ||
| "--no-randomize", | ||
| # Timeout handling requires subprocesses; explicitly setting | ||
| # the timeout to -1 disables the faulthandler. | ||
| "--timeout=-1", | ||
| # Adding Python options requires the use of a subprocess to | ||
| # start a new Python interpreter. | ||
| "--dont-add-python-opts", | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
However, resolving this in the Android testbed required a fairly significant refactoring, so since this PR doesn't make the iOS situation any worse, it's probably best left to a separate PR.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure I agree it's reducing effectiveness. It's preventing the use of a code branch that would otherwise be invoked as a consequence of using I agree that the Python options that are enabled by that code branch should be factored into the iOS testbed - but as you have flagged, that would requires a much more substantial refactor, and it can be handled independently.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sounds good. FYI, the reason why I made the Android testbed accept Python options on the command line, rather than hard-coding the options expected by the CPython test suite, is that some of those options might not be appropriate for third-party package tests run by cibuildwheel.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sure - that makes sense. I've got some ideas for how this could be managed in the context of the iOS testbed - we can read options out of the Info.plist file to separate test suite options from interpreter options.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I found it simpler not to separate them at all, but to let |
||
| ] | ||
| ) | ||
|
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.