Skip to content

gh-137396: Raise InvalidHeaderError when offset or numbytes is negative#137805

Open
moreal wants to merge 1 commit into
python:mainfrom
moreal:gh-137396
Open

gh-137396: Raise InvalidHeaderError when offset or numbytes is negative#137805
moreal wants to merge 1 commit into
python:mainfrom
moreal:gh-137396

Conversation

@moreal
Copy link
Copy Markdown
Contributor

@moreal moreal commented Aug 15, 2025 •
edited by bedevere-app Bot
Loading

@bedevere-app bedevere-app Bot mentioned this pull request Aug 15, 2025
Open
corona10
corona10 reviewed Aug 15, 2025
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2025-08-15-06-45-30.gh-issue-137396.h10zyu.rst Outdated
@@ -0,0 +1,2 @@
:func:`tarfile.Tarfile.fromtarfile` and :func:`tarfile.TarInfo.frombuf` raises
Copy link
Copy Markdown
Member

@corona10 corona10 Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/home/runner/work/cpython/cpython/Doc/build/NEWS:191: WARNING: py:func reference target not found: tarfile.Tarfile.fromtarfile [ref.func]

See docs CI failure

Copy link
Copy Markdown
Contributor Author

@moreal moreal Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@corona10 I rewrote the NEWS file and it seems succeeded now.

The #137396 issue now has type-security label, then should I move the file to the Misc/NEWS.d/next/Security directory?

Copy link
Copy Markdown
Member

@picnixz picnixz Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason why this fails is because fromtarfile is a classmethod of TarInfo not TarFile. Also, when referencing methods, it's better to use the meth role rather than the func one.

@moreal moreal marked this pull request as ready for review August 15, 2025 07:37
@moreal moreal requested a review from ethanfurman as a code owner August 15, 2025 07:37
@sethmlarson
Copy link
Copy Markdown
Contributor

sethmlarson commented Aug 18, 2025

Can we put guards around all values that we expect to be positive or zero? I'm thinking:

  • size
  • origsize
  • mtime (this one is actually called out in tar standard, time values must be positive).

@picnixz
Copy link
Copy Markdown
Member

picnixz commented Aug 18, 2025

Can we put guards around all values that we expect to be positive or zero? I'm thinking:

One way to do it is to add a flag to nti so that we raise a ValueError if the parsed value is negative, or to check all nti calls individually.

@ZeroIntensity ZeroIntensity mentioned this pull request Sep 16, 2025
Closed
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 28, 2026

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 left review comments

@picnixz picnixz picnixz left review comments

@ethanfurman ethanfurman Awaiting requested review from ethanfurman ethanfurman is a code owner

Assignees

@gpshead gpshead

Labels

awaiting review sprint stale Stale PR or inactive for long period of time.

Projects

Sprint 2024
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@moreal @sethmlarson @picnixz @corona10 @gpshead