Skip to content

bpo-5680: IDLE: Customize running a module. #13763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
terryjreedy merged 19 commits into from
Jun 18, 2019
Merged

bpo-5680: IDLE: Customize running a module. #13763

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
ffc22b8
bpo-5680: IDLE: Run modules with command line arguments
csabella Jun 3, 2019
36f7771
📜🤖 Added by blurb_it.
blurb-it[bot] Jun 3, 2019
69cf1b6
Fix editing error
csabella Jun 3, 2019
dbdd580
Create more generic dialog and change keybinding
csabella Jun 3, 2019
f1e7c61
Don't show warning message for new key binding
csabella Jun 6, 2019
286e4c6
Merge remote-tracking branch 'origin/master' into pr_13763
terryjreedy Jun 15, 2019
03e0f59
Change menu entry 'Run Custom' to 'Run ... Customized'.
terryjreedy Jun 16, 2019
22bb3a2
Expand blurb.
terryjreedy Jun 16, 2019
35f0379
Polish run.py.
terryjreedy Jun 16, 2019
09f37d7
In runscript, pass run_args.
terryjreedy Jun 16, 2019
8d98622
More runscript edit.
terryjreedy Jun 16, 2019
8c8bb4d
Edit query and tests.
terryjreedy Jun 16, 2019
845178b
Move some test dummy attributes to instance.
terryjreedy Jun 16, 2019
31416fd
A couple more.
terryjreedy Jun 16, 2019
fbfca23
Update query coverage.
terryjreedy Jun 16, 2019
4da67c3
pass rub_args by keyword
terryjreedy Jun 16, 2019
307ac6a
Merge branch 'master' into bpo5680
terryjreedy Jun 17, 2019
4a64274
Show customize box after check, attach to shell.
terryjreedy Jun 18, 2019
18177da
Minor tweaks.
terryjreedy Jun 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Polish run.py.
  • Loading branch information
@terryjreedy
terryjreedy committed Jun 16, 2019
commit 35f03799f5389b72b931bb1d473a0b58d170f80f
9 changes: 4 additions & 5 deletions Lib/idlelib/runscript.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,15 +109,15 @@ def run_module_event(self, event):
# tries to run a module using the keyboard shortcut
# (the menu item works fine).
self.editwin.text_frame.after(200,
lambda: self.editwin.text_frame.event_generate('<<run-module-event-2>>'))
lambda: self.editwin.text_frame.event_generate(
'<<run-module-event-2>>'))
return 'break'
else:
return self._run_module_event(event)

def run_custom_event(self, event):
run_args = CustomRun(event.widget, "Customize Run").result
# User cancelled.
if not run_args:
if not run_args: # User cancelled.
return 'break'
return self._run_module_event(event, cli_args=run_args[0], restart=run_args[1])
Copy link
Copy Markdown
Member

@terryjreedy terryjreedy Jun 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to pass run_args and unpack in _run_module.


Expand All @@ -143,9 +143,8 @@ def _run_module_event(self, event, *, cli_args=None, restart=True):
self.editwin._filename_to_unicode(filename))
dirname = os.path.dirname(filename)
argv = [filename]
if cli_args:
if cli_args is not None:
argv += cli_args
# XXX Too often this discards arguments the user just set...
interp.runcommand(f"""if 1:
__file__ = {filename!r}
import sys as _sys
Expand Down