Skip to content

bpo-37100: Fix test_coroutines with -Werror #13756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 1 commit into from
Jun 2, 2019
Merged

bpo-37100: Fix test_coroutines with -Werror #13756

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Lib/test/test_coroutines.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2250,7 +2250,8 @@ async def corofn():
try:
warnings._warn_unawaited_coroutine = lambda coro: 1/0
with support.catch_unraisable_exception() as cm, \
support.captured_stderr() as stream:
support.check_warnings((r'coroutine .* was never awaited',
RuntimeWarning)):
# only store repr() to avoid keeping the coroutine alive
coro = corofn()
coro_repr = repr(coro)
Expand All @@ -2261,13 +2262,12 @@ async def corofn():

self.assertEqual(repr(cm.unraisable.object), coro_repr)
self.assertEqual(cm.unraisable.exc_type, ZeroDivisionError)
self.assertIn("was never awaited", stream.getvalue())

del warnings._warn_unawaited_coroutine
with support.captured_stderr() as stream:
with support.check_warnings((r'coroutine .* was never awaited',
RuntimeWarning)):
corofn()
support.gc_collect()
self.assertIn("was never awaited", stream.getvalue())

finally:
warnings._warn_unawaited_coroutine = orig_wuc
Expand Down