Skip to content

gh-124111: test macOS CI with Tk 9#137424

Merged
ned-deily merged 3 commits into
python:mainfrom
hugovk:3.15-gh-124111-macos-ci-tk9
Oct 14, 2025
Merged

gh-124111: test macOS CI with Tk 9#137424
ned-deily merged 3 commits into
python:mainfrom
hugovk:3.15-gh-124111-macos-ci-tk9

Conversation

@hugovk

@hugovk hugovk commented Aug 5, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Includes #136959 and fixes the tests for Tcl/Tk 9.

New PR because I couldn't push to that one:

Details 
❯ git push
Enumerating objects: 13, done.
Counting objects: 100% (13/13), done.
Delta compression using up to 8 threads
Compressing objects: 100% (7/7), done.
Writing objects: 100% (7/7), 1.26 KiB | 1.26 MiB/s, done.
Total 7 (delta 6), reused 0 (delta 0), pack-reused 0 (from 0)
remote: Resolving deltas: 100% (6/6), completed with 6 local objects.
remote: error: GH006: Protected branch update failed for refs/heads/gh-124111-macos-ci-tk9.
remote:
remote: - Changes must be made through a pull request.
To https://github.com/ned-deily/cpython.git
 ! [remote rejected]         gh-124111-macos-ci-tk9 -> gh-124111-macos-ci-tk9 (protected branch hook declined)
error: failed to push some refs to 'https://github.com/ned-deily/cpython.git'

@bedevere-app bedevere-app Bot mentioned this pull request Aug 5, 2025
Open
@hugovk hugovk marked this pull request as ready for review August 5, 2025 16:45
@hugovk hugovk mentioned this pull request Aug 5, 2025
Closed
@ned-deily

ned-deily commented Aug 5, 2025

Copy link
Copy Markdown
Member

FYI @culler @serhiy-storchaka

@culler

culler commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

Thanks for the good news!

By the way, Tcl/Tk 9.0.2 was released on July 2.

@ned-deily ned-deily merged commit 9c1279d into python:main Oct 14, 2025
43 checks passed
@hugovk hugovk deleted the 3.15-gh-124111-macos-ci-tk9 branch October 14, 2025 05:40
@hugovk

hugovk commented Oct 14, 2025

Copy link
Copy Markdown
Member Author

Should we backport?

In #124111 (comment), @serhiy-storchaka said:

  • Any test changes should be backported. This would help future bugfix backports and help to compare versions if we have a regression. Tests should be passed with older Tcl/Tk versions.

So backport the test changes to 3.13, but leave macOS CI on tcl-tk@8?

@ned-deily

ned-deily commented Oct 14, 2025

Copy link
Copy Markdown
Member

Probably. And backport the whole PR to 3.14. But it might be good to wait for 3.15.0a1 to get out the door first.

@serhiy-storchaka serhiy-storchaka mentioned this pull request Jul 10, 2026
Merged
serhiy-storchaka added a commit that referenced this pull request Jul 11, 2026
@serhiy-storchaka
[3.13] gh-128846: Make tkinter tests robust against Tcl/Tk 9.0 (GH-15…
59e183c 
…3484)

Backport the test-only parts of the Tcl/Tk 8.7/9.0/9.1 test adaptations so
that test_tkinter and test_ttk pass when Python 3.13 is built against
Tcl/Tk 9.0 (for example the Homebrew build used on macOS), while still
passing against the Tcl/Tk 8.6 that 3.13 ships.

Combines the test changes from:

* gh-124111: Update tkinter for compatibility with Tcl/Tk 9.0.0 (GH-124156)
* gh-124111: test macOS CI with Tk 9 (GH-137424)
* gh-145736: Fix Tkinter tests for Tk 8.7, 9.0 and 9.1 (GH-145738)

The corresponding non-test changes (Modules/_tkinter.c, Lib/tkinter/ttk.py,
PCbuild and CI configuration) are not backported.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ned-deily ned-deily ned-deily approved these changes
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees

No one assigned

Labels

OS-mac skip news topic-tkinter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hugovk @ned-deily @culler