Skip to content

gh-135228: When @dataclass(slots=True) replaces a dataclass, make the original class collectible (take 2) #137047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encukou merged 9 commits into from
Aug 12, 2025
Merged

gh-135228: When @dataclass(slots=True) replaces a dataclass, make the original class collectible (take 2) #137047

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
916ce1b
gh-135228: When @dataclass(slots=True) replaces a dataclass, make the…
JelleZijlstra Jul 22, 2025
6dc0f48
Use a new private sys function instead
JelleZijlstra Jul 23, 2025
b9fb155
obsolete comment
JelleZijlstra Jul 23, 2025
52c7d2b
restrict to heap types
JelleZijlstra Jul 23, 2025
250f3e9
more paranoid
JelleZijlstra Jul 25, 2025
a9483b4
Apply suggestions from code review
JelleZijlstra Jul 29, 2025
8c2c1e1
Update Python/sysmodule.c
JelleZijlstra Jul 30, 2025
2d3bd7c
Feedback from Petr
JelleZijlstra Aug 5, 2025
06618d8
use AC for type checking
JelleZijlstra Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
use AC for type checking
  • Loading branch information
@JelleZijlstra
JelleZijlstra committed Aug 12, 2025
commit 06618d8804ecc123f8eb1da1fb6a6f131da93af0
22 changes: 21 additions & 1 deletion Python/clinic/sysmodule.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 4 additions & 8 deletions Python/sysmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2644,7 +2644,7 @@ sys__baserepl_impl(PyObject *module)
/*[clinic input]
sys._clear_type_descriptors

type: object
type: object(subclass_of='&PyType_Type')
/

Private function for clearing certain descriptors from a type's dictionary.
Expand All @@ -2653,14 +2653,10 @@ See gh-135228 for context.
[clinic start generated code]*/

static PyObject *
sys__clear_type_descriptors(PyObject *module, PyObject *type)
/*[clinic end generated code: output=7d5cefcf861909e0 input=5fdc23500d477de6]*/
sys__clear_type_descriptors_impl(PyObject *module, PyObject *type)
/*[clinic end generated code: output=5ad17851b762b6d9 input=dc536c97fde07251]*/
{
if (!PyType_Check(type)) {
PyErr_SetString(PyExc_TypeError, "argument must be a type");
return NULL;
}
PyTypeObject *typeobj = (PyTypeObject *)(type);
PyTypeObject *typeobj = (PyTypeObject *)type;
if (_PyType_HasFeature(typeobj, Py_TPFLAGS_IMMUTABLETYPE)) {
PyErr_SetString(PyExc_TypeError, "argument is immutable");
return NULL;
Expand Down
Loading