Skip to content

gh-135228: When @dataclass(slots=True) replaces a dataclass, make the original class collectible #136893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 3 commits into from
Jul 22, 2025
Merged

gh-135228: When @dataclass(slots=True) replaces a dataclass, make the original class collectible #136893

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
027f629
gh-135228: When @dataclass(slots=True) replaces a dataclass, make the…
JelleZijlstra Jul 20, 2025
e0d61f7
Apply suggestions from code review
JelleZijlstra Jul 22, 2025
d545002
Update Lib/dataclasses.py
JelleZijlstra Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Alyssa Coghlan <ncoghlan@gmail.com>
  • Loading branch information
@JelleZijlstra @ncoghlan
JelleZijlstra and ncoghlan authored Jul 22, 2025
commit e0d61f7a8655e7a3f1fcc035e3c1b9fc4af4d9b4
3 changes: 2 additions & 1 deletion Lib/dataclasses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1339,9 +1339,10 @@ def _add_slots(cls, is_frozen, weakref_slot, defined_fields):
break

# gh-135228: Make sure the original class can be garbage collected.
# Bypass mapping proxy to allow __dict__ to be removed
old_cls_dict = cls.__dict__ | _deproxier
Comment thread
JelleZijlstra marked this conversation as resolved.
old_cls_dict.pop('__weakref__', None)
old_cls_dict.pop('__dict__', None)
del cls.__weakref__
Comment thread
JelleZijlstra marked this conversation as resolved.
Outdated

return newcls

Expand Down
Loading