gh-136854: Exit on error in make venv#136856
Merged
Merged
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
hugovk
approved these changes
Jul 20, 2025
hugovk
left a comment
Member
There was a problem hiding this comment.
Thanks!
There's a similar Makefile in the PEPs repo, would you like to do the triple?
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 20, 2025
(cherry picked from commit 9c2f91c) Co-authored-by: Nacho Caballero <nachocab@gmail.com> Co-authored-by: Nacho Caballero <nacho.caballero@astrazeneca.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 20, 2025
(cherry picked from commit 9c2f91c) Co-authored-by: Nacho Caballero <nachocab@gmail.com> Co-authored-by: Nacho Caballero <nacho.caballero@astrazeneca.com>
|
GH-136860 is a backport of this pull request to the 3.14 branch. |
|
GH-136861 is a backport of this pull request to the 3.13 branch. |
picnixz
pushed a commit
to picnixz/cpython
that referenced
this pull request
Jul 20, 2025
Co-authored-by: Nacho Caballero <nacho.caballero@astrazeneca.com>
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
Co-authored-by: Nacho Caballero <nacho.caballero@astrazeneca.com>
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
Co-authored-by: Nacho Caballero <nacho.caballero@astrazeneca.com>
kumaraditya303
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 9, 2025
python#136860) Co-authored-by: Nacho Caballero <nachocab@gmail.com> Co-authored-by: Nacho Caballero <nacho.caballero@astrazeneca.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #136854
make venvfrom saying it succeeded when it failed #136854📚 Documentation preview 📚: https://cpython-previews--136856.org.readthedocs.build/