Skip to content

Fix a minor indentation error#136661

Merged
gaogaotiantian merged 2 commits into
python:mainfrom
gaogaotiantian:fix-indentation-error
Jul 15, 2025
Merged

Fix a minor indentation error#136661
gaogaotiantian merged 2 commits into
python:mainfrom
gaogaotiantian:fix-indentation-error

Conversation

@gaogaotiantian
Copy link
Copy Markdown
Member

@gaogaotiantian gaogaotiantian commented Jul 14, 2025

Not sure if this counts as a "cosmetic change" but this did confuse me for a few seconds. I believe this is a typo when Mark check in the code.

@gaogaotiantian gaogaotiantian merged commit db20324 into python:main Jul 15, 2025
40 checks passed
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Jul 15, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.x (tier-1) has failed when building commit db20324.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/345/builds/11815) and take a look at the build logs.
  4. Check if the failure is related to this commit (db20324) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/345/builds/11815

Failed tests:

  • test_math

Failed subtests:

  • test_sumprod_stress - test.test_math.MathTests.test_sumprod_stress
  • test_eq_with_mutation - test.test_set.TestBinaryOpsMutating_Set_Set.test_eq_with_mutation

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_math.py", line 1571, in test_sumprod_stress
    run(baseline_sumprod, *args),
    ~~~^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/case.py", line 723, in __call__
    return self.run(*args, **kwds)
           ~~~~~~~~^^^^^^^^^^^^^^^
TypeError: TestCase.run() takes from 1 to 2 positional arguments but 4 were given


Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_set.py", line 1908, in test_eq_with_mutation
    self.check_set_op_does_not_crash(lambda a, b: a == b)
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_set.py", line 1897, in check_set_op_does_not_crash
    set1, set2 = self.make_sets_of_bad_objects()
                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_set.py", line 1890, in make_sets_of_bad_objects
    set2 = self.constructor2(Bad() for _ in range(randrange(50)))
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_set.py", line 1886, in __hash__
    return randrange(2)
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/random.py", line 312, in randrange
    raise ValueError("empty range for randrange()")
ValueError: empty range for randrange()

@Anawaert
Copy link
Copy Markdown

Anawaert commented Jul 15, 2025

The fact proves that taking travel can improve eyesight when reviewing code : )

taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@gaogaotiantian @taegyunkim
Fix a minor indentation error (python#136661)
af33816
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@gaogaotiantian @Agent-Hellboy
Fix a minor indentation error (python#136661)
05a3743
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

@markshannon markshannon Awaiting requested review from markshannon

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gaogaotiantian @bedevere-bot @Anawaert @iritkatriel