Skip to content

gh-134043: use stackrefs for dict lookup in _PyObject_GetMethodStackRef #136412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumaraditya303 merged 12 commits into from
Jul 28, 2025
Merged

gh-134043: use stackrefs for dict lookup in _PyObject_GetMethodStackRef #136412

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
3108bbe
use stackrefs for dict loopkup
kumaraditya303 Jul 7, 2025
a5498aa
add back comment
kumaraditya303 Jul 8, 2025
e4c36a8
avoid incref/decref for unicode keys dict
kumaraditya303 Jul 9, 2025
c889427
format
kumaraditya303 Jul 9, 2025
6468c7c
fix compliation
kumaraditya303 Jul 9, 2025
7a858d6
Merge remote-tracking branch 'upstream/main' into dict
kumaraditya303 Jul 11, 2025
109ff8b
Merge remote-tracking branch 'upstream/main' into dict
kumaraditya303 Jul 17, 2025
aadb482
add _Py_dict_lookup_unicode_threadsafe_stackref to lookup method
kumaraditya303 Jul 18, 2025
5e79d52
fix merge
kumaraditya303 Jul 18, 2025
bbc7fb8
Refactor
colesbury Jul 21, 2025
71864c1
Merge pull request #19 from colesbury/dict-refactor
kumaraditya303 Jul 21, 2025
1a02ae6
fix cast
kumaraditya303 Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix cast
  • Loading branch information
@kumaraditya303
kumaraditya303 committed Jul 21, 2025
commit 1a02ae6305819cb96204318d2f1b016998518b3b
2 changes: 1 addition & 1 deletion Objects/dictobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1672,7 +1672,7 @@ _PyDict_GetMethodStackRef(PyDictObject *mp, PyObject *key, _PyStackRef *method)
#ifdef Py_GIL_DISABLED
PyDictKeysObject *dk = _Py_atomic_load_ptr_acquire(&mp->ma_keys);
if (dk->dk_kind == DICT_KEYS_UNICODE) {
_PyStackRef ref; //
_PyStackRef ref;
Py_ssize_t ix = lookup_threadsafe_unicode(dk, key, hash, &ref);
if (ix >= 0) {
assert(!PyStackRef_IsNull(ref));
Expand Down
2 changes: 1 addition & 1 deletion Objects/object.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1754,7 +1754,7 @@ _PyObject_GetMethodStackRef(PyThreadState *ts, PyObject *obj,
}
if (dict != NULL) {
assert(PyUnicode_CheckExact(name));
int found = _PyDict_GetMethodStackRef(dict, name, method);
int found = _PyDict_GetMethodStackRef((PyDictObject *)dict, name, method);
if (found < 0) {
assert(PyStackRef_IsNull(*method));
return -1;
Expand Down
Loading