Skip to content

bpo-37029: keep usable_arenas in sorted order without searching #13612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tim-one merged 5 commits into from
Jun 1, 2019
Merged

bpo-37029: keep usable_arenas in sorted order without searching #13612

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c691a69
Issue 37029: first stab at removing all searching to keep usable_arenas
tim-one May 28, 2019
f4a60e8
📜🤖 Added by blurb_it.
blurb-it[bot] May 28, 2019
efe1e63
Beefed up an assert; added the BPO number to a comment.
tim-one May 28, 2019
0b36d42
Merge branch 'remove-arena-search' of https://github.com/tim-one/cpyt…
tim-one May 28, 2019
0463a7d
And added one more assert.
tim-one May 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
📜🤖 Added by blurb_it.
  • Loading branch information
@blurb-it
blurb-it[bot] committed May 28, 2019
commit f4a60e85238dd54dfd6702d6751b55303a1ed153
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core and Builtins/2019-05-28-17-02-46.bpo-37029.MxpgfJ.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Freeing a great many small objects could take time quadratic in the number of arenas, due to using linear search to keep ``obmalloc.c``'s list of usable arenas sorted by order of number of free memory pools. This is accomplished without search now, leaving the worst-case time linear in the number of arenas. For programs where this quite visibly matters (typically with more than 100 thousand small objects alive simultaneously), this can greatly reduce the time needed to release their memory.