Skip to content

gh-133390: Support table, index, trigger, view, column, function, and schema completion in the sqlite3 CLI #136101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encukou merged 14 commits into from
Oct 24, 2025
Merged

gh-133390: Support table, index, trigger, view, column, function, and schema completion in the sqlite3 CLI #136101

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
7164755
Support table, index, trigger, view, column, function, and schema com…
tanloong Jun 24, 2025
a641e59
blurb add
tanloong Jun 29, 2025
0bfc0fd
Merge branch 'main' into sqlite3-cli-completion-table-index-triger-vi…
tanloong Jul 1, 2025
47d7fb4
Add what's new
tanloong Jul 1, 2025
393e24c
Merge branch 'main' into sqlite3-cli-completion-table-index-triger-vi…
tanloong Aug 9, 2025
dfd3721
Merge branch 'main' into sqlite3-cli-completion-table-index-triger-vi…
tanloong Oct 4, 2025
62b9dc5
Merge branch 'main' into sqlite3-cli-completion-table-index-triger-vi…
tanloong Oct 8, 2025
164a9e1
use SQLite for more of manipulating and filtering
tanloong Oct 8, 2025
2c99f21
formatting
tanloong Oct 9, 2025
088e741
add comment
tanloong Oct 9, 2025
445e279
test case-insensitive completion
tanloong Oct 12, 2025
10f09e0
Merge branch 'main' into sqlite3-cli-completion-table-index-triger-vi…
tanloong Oct 12, 2025
658d41c
skip PRAGMA-dependent completion tests on older SQLite versions (3.16…
tanloong Oct 12, 2025
48c60bf
add another assertion
tanloong Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test case-insensitive completion
  • Loading branch information
@tanloong
tanloong committed Oct 12, 2025
commit 445e27993a8279a5862a8cbdfa6e108064eac7e1
69 changes: 37 additions & 32 deletions Lib/test/test_sqlite3/test_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,24 +264,24 @@ def test_complete_sql_keywords(self):

def test_complete_table_indexes_triggers_views(self):
input_ = textwrap.dedent("""\
CREATE TABLE _table (id);
CREATE INDEX _index ON _table (id);
CREATE TRIGGER _trigger BEFORE INSERT
ON _table BEGIN SELECT 1; END;
CREATE VIEW _view AS SELECT 1;

CREATE TEMP TABLE _temp_table (id);
CREATE INDEX temp._temp_index ON _temp_table (id);
CREATE TEMP TRIGGER _temp_trigger BEFORE INSERT
ON _table BEGIN SELECT 1; END;
CREATE TEMP VIEW _temp_view AS SELECT 1;
CREATE TABLE _Table (id);
CREATE INDEX _Index ON _table (id);
CREATE TRIGGER _Trigger BEFORE INSERT
ON _Table BEGIN SELECT 1; END;
CREATE VIEW _View AS SELECT 1;

CREATE TEMP TABLE _Temp_table (id);
CREATE INDEX temp._Temp_index ON _Temp_table (id);
CREATE TEMP TRIGGER _Temp_trigger BEFORE INSERT
ON _Table BEGIN SELECT 1; END;
CREATE TEMP VIEW _Temp_view AS SELECT 1;

ATTACH ':memory:' AS attached;
CREATE TABLE attached._attached_table (id);
CREATE INDEX attached._attached_index ON _attached_table (id);
CREATE TRIGGER attached._attached_trigger BEFORE INSERT
ON _attached_table BEGIN SELECT 1; END;
CREATE VIEW attached._attached_view AS SELECT 1;
CREATE TABLE attached._Attached_table (id);
CREATE INDEX attached._Attached_index ON _Attached_table (id);
CREATE TRIGGER attached._Attached_trigger BEFORE INSERT
ON _Attached_table BEGIN SELECT 1; END;
CREATE VIEW attached._Attached_view AS SELECT 1;

SELECT id FROM _\t\tta\t;
Copy link
Copy Markdown
Member

@encukou encukou Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last \t (after _a) isn't tested. Did you mean to add another assertion with start, end = indices[-2], indices[-1]?

Copy link
Copy Markdown
Contributor Author

@tanloong tanloong Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review! I will add it.

.quit\n""").encode()
Expand All @@ -293,18 +293,18 @@ def test_complete_table_indexes_triggers_views(self):
candidates = [l.strip() for l in lines[start+1:end]]
self.assertEqual(candidates,
[
"_attached_index",
"_attached_table",
"_attached_trigger",
"_attached_view",
"_index",
"_table",
"_temp_index",
"_temp_table",
"_temp_trigger",
"_temp_view",
"_trigger",
"_view",
"_Attached_index",
"_Attached_table",
"_Attached_trigger",
"_Attached_view",
"_Index",
"_Table",
"_Temp_index",
"_Temp_table",
"_Temp_trigger",
"_Temp_view",
"_Trigger",
"_View",
],
)

Expand Down Expand Up @@ -343,19 +343,24 @@ def test_complete_functions(self):

def test_complete_schemata(self):
input_ = textwrap.dedent("""\
ATTACH ':memory:' AS _attached;
ATTACH ':memory:' AS MixedCase;
-- Test '_' is escaped in Like pattern filtering
ATTACH ':memory:' AS _underscore;
-- Let database_list pragma have a 'temp' schema entry
CREATE TEMP TABLE _table (id);

SELECT * FROM \t\t_att\t.sqlite_master;
SELECT * FROM \t\tmIX\t.sqlite_master;
SELECT * FROM _und\t.sqlite_master;
.quit\n""").encode()
output = self.write_input(input_)
lines = output.decode().splitlines()
indices = [
i for i, line in enumerate(lines) if line.startswith(self.PS1)
]
start, end = indices[-3], indices[-2]
start, end = indices[-4], indices[-3]
candidates = [l.strip() for l in lines[start+1:end]]
self.assertIn("_attached", candidates)
self.assertIn("MixedCase", candidates)
self.assertIn("_underscore", candidates)
self.assertIn("main", candidates)
self.assertIn("temp", candidates)

Expand Down