Skip to content

gh-123681: Check NORMALIZE_CENTURY behavior at runtime; require C99 #136022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encukou merged 10 commits into from
Aug 19, 2025
Merged

gh-123681: Check NORMALIZE_CENTURY behavior at runtime; require C99 #136022

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0d17190
gh-123681: Check the strftime() behavior at runtime instead of at the…
serhiy-storchaka Jan 3, 2025
695f58f
Merge branch 'main' into strftime-runtime-checks
serhiy-storchaka Apr 8, 2025
26441f9
Add static variables to ignored.tsv.
serhiy-storchaka Apr 8, 2025
65cf376
Merge branch 'main' into strftime-runtime-checks
serhiy-storchaka Apr 9, 2025
872a3e0
Merge in the main branch; run `make regen-configure`
encukou Jun 27, 2025
8231ace
CPython needs C99
encukou Jun 27, 2025
edf4428
Remove _can_support_c99 from _pydatetime.py
encukou Jul 1, 2025
a52be23
Merge in the main branch
encukou Jul 8, 2025
83c8cff
Apply suggestions from code review
encukou Aug 19, 2025
631f95e
Merge branch 'main' into strftime-c99-always
encukou Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove _can_support_c99 from _pydatetime.py
  • Loading branch information
@encukou
encukou committed Jul 1, 2025
commit edf4428a59eecb2b547c92a0e19d9bbf3c2743d0
13 changes: 1 addition & 12 deletions Lib/_pydatetime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,17 +213,6 @@ def _need_normalize_century():
_normalize_century = True
return _normalize_century

_supports_c99 = None
def _can_support_c99():
global _supports_c99
if _supports_c99 is None:
try:
_supports_c99 = (
_time.strftime("%F", (1900, 1, 1, 0, 0, 0, 0, 1, 0)) == "1900-01-01")
except ValueError:
_supports_c99 = False
return _supports_c99

# Correctly substitute for %z and %Z escapes in strftime formats.
def _wrap_strftime(object, format, timetuple):
# Don't call utcoffset() or tzname() unless actually needed.
Expand Down Expand Up @@ -283,7 +272,7 @@ def _wrap_strftime(object, format, timetuple):
newformat.append(Zreplace)
# Note that datetime(1000, 1, 1).strftime('%G') == '1000' so
# year 1000 for %G can go on the fast path.
elif ((ch in 'YG' or ch in 'FC' and _can_support_c99()) and
elif ((ch in 'YG' or ch in 'FC') and
object.year < 1000 and _need_normalize_century()):
if ch == 'G':
year = int(_time.strftime("%G", timetuple))
Expand Down
Loading