Skip to content

gh-91048: Fix external inspection multi-threaded performance #136005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 9 commits into from
Jun 28, 2025
Merged

gh-91048: Fix external inspection multi-threaded performance #136005

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e9ec2fa
gh-91048: Fix external inspection multi-threaded performance
pablogsal Jun 26, 2025
0663518
Remove the cache as it was making things worse
pablogsal Jun 27, 2025
ab299f4
Fix perf script
pablogsal Jun 27, 2025
d166146
Regen files
pablogsal Jun 27, 2025
03f447e
FIx race
pablogsal Jun 27, 2025
f1b1e4f
FIx race
pablogsal Jun 28, 2025
04f8748
FIx race
pablogsal Jun 28, 2025
63261de
FIx race
pablogsal Jun 28, 2025
99622fb
FIx race
pablogsal Jun 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
FIx race
  • Loading branch information
@pablogsal
pablogsal committed Jun 28, 2025
commit 99622fbff5bb350f45babd8c9f14a90c0251e427
1 change: 0 additions & 1 deletion Lib/test/test_external_inspection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
import sys
import socket
import threading
import time
from asyncio import staggered, taskgroups, base_events, tasks
from unittest.mock import ANY
from test.support import os_helper, SHORT_TIMEOUT, busy_retry, requires_gil_enabled
Expand Down
8 changes: 8 additions & 0 deletions Modules/_remote_debugging_module.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2537,6 +2537,14 @@ _remote_debugging_RemoteUnwinder___init___impl(RemoteUnwinderObject *self,
return -1;
}

#ifdef Py_GIL_DISABLED
if (only_active_thread) {
PyErr_SetString(PyExc_ValueError,
"only_active_thread is not supported when Py_GIL_DISABLED is not defined");
return -1;
}
#endif

self->debug = debug;
self->only_active_thread = only_active_thread;
self->cached_state = NULL;
Expand Down
Loading