Skip to content

bpo-37039: IDLE - zoomheight fixes #13576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
terryjreedy merged 5 commits into from
May 27, 2019
Merged

bpo-37039: IDLE - zoomheight fixes #13576

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e43e90e
bpo-37039: IDLE fixes for zoomheight
terryjreedy May 25, 2019
a537437
On Windows, zoom less to avoid underlapping Win10 taskbar.
terryjreedy May 25, 2019
65fb242
More refactoring.
terryjreedy May 25, 2019
4d885e3
Delete () not needed for 1 line.
terryjreedy May 25, 2019
62ad3f3
Revert change only good for my system.
terryjreedy May 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
More refactoring.
  • Loading branch information
@terryjreedy
terryjreedy committed May 25, 2019
commit 65fb24251394cdec7f6f6be186901dbeda85324d
14 changes: 4 additions & 10 deletions Lib/idlelib/zoomheight.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,16 +31,10 @@ def zoom_height(top):

# The constants below for Windows and Mac Aqua are visually determined
# to avoid taskbar or menubar and app icons.
if sys.platform == 'win32':
newy = 0
newheight = newheight - 114
elif macosx.isAquaTk():
newy = 22
newheight = newheight - newy - 88
else:
newy = 0
newheight = newheight - 88

newy, bot_y = ((0, 114) if sys.platform == 'win32' else
(22, 88) if macosx.isAquaTk() else
(0, 88) ) # Guess for anything else.
newheight = newheight - newy - bot_y
newgeom = ('' if height >= newheight else f"{width}x{newheight}+{x}+{newy}")
top.wm_geometry(newgeom)
return newgeom != ""
Expand Down