Skip to content

[3.14] gh-127146: Emscripten: Skip test_url2pathname_resolve_host (GH-135634) #135651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
freakboy3742 merged 1 commit into from
Jun 18, 2025
Merged

[3.14] gh-127146: Emscripten: Skip test_url2pathname_resolve_host (GH-135634) #135651

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
gh-127146: Emscripten: Skip test_url2pathname_resolve_host (GH-135634) 
Emscripten currently `gethostbyname_r()` returns an incorrect
IP address for `localhost`. Will be resolved by upstream PR:
emscripten-core/emscripten#24593
(cherry picked from commit 2a49c54)

Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
  • Loading branch information
@hoodmane @miss-islington
hoodmane authored and miss-islington committed Jun 18, 2025
commit 630562bf7ecd3a1a7d7fafa18d41fa2ea99de4b7
1 change: 1 addition & 0 deletions Lib/test/test_urllib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1569,6 +1569,7 @@ def test_url2pathname_require_scheme_errors(self):
urllib.request.url2pathname,
url, require_scheme=True)

@unittest.skipIf(support.is_emscripten, "Fixed by https://github.com/emscripten-core/emscripten/pull/24593")
def test_url2pathname_resolve_host(self):
fn = urllib.request.url2pathname
sep = os.path.sep
Expand Down
Loading