Clean up some confusing text left by PROTOCOL_SSLv23 -> PROTOCOL_TLS transition#1355
Merged
Conversation
…transition It was confusing that PROTOCOL_SSLv23 could negotiate TLS connections. It is not confusing that PROTOCOL_TLS can negotiate TLS connections. In fact it is confusing that the docs thought it was confusing.
Contributor
Author
|
(This should have the "trivial" label, but I don't have permissions to add it.) |
tiran
approved these changes
Apr 29, 2017
Member
tiran
left a comment
There was a problem hiding this comment.
LGTM
SSLv23 is an artefact from the time when OpenSSL just had support for SSLv2 and SSLv3. It took me years do understand that PROTOCOL_SSLv23 actually means auto-negotiation of the highest protocol enabled on both sides.
Mariatta
approved these changes
May 2, 2017
Mariatta
pushed a commit
to Mariatta/cpython
that referenced
this pull request
May 2, 2017
…L_TLS transition (pythonGH-1355) (cherry picked from commit d4069de)
Contributor
Contributor
|
Sorry, @njsmith and @Mariatta, I could not cleanly backport this to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was confusing that PROTOCOL_SSLv23 could negotiate TLS connections. It is not confusing that PROTOCOL_TLS can negotiate TLS connections. In fact it is confusing that the docs thought it was confusing.