bpo-30207: Rename test.test_support to test.support.#1353
Merged
Conversation
The test.test_support module was converted into package and renamed to test.support. The test.script_helper module was moved into the test.support package. Names test.test_support and test.script_helper are left as aliases to test.support and test.support.script_helper.
ncoghlan
approved these changes
Apr 30, 2017
ncoghlan
left a comment
Contributor
There was a problem hiding this comment.
The actual change looks good to me, just a couple of suggested wording tweaks to the docs note and the NEWS entry.
|
|
||
| The :mod:`test.test_support` module has been renamed to :mod:`test.support` | ||
| in Python 3.x. | ||
| The :mod:`test.support` module has been renamed to :mod:`test.support` |
Contributor
There was a problem hiding this comment.
This should start with "The test.test_support module..." and explicitly state that the latter has been retained as an alias in 2.7.x.
| Tests | ||
| ----- | ||
|
|
||
| - bpo-30207: The test.test_support module was converted into package and |
Contributor
There was a problem hiding this comment.
I'd suggest starting the NEWS entry with the rationale for the change: "To simplify backports from Python 3, ..."
Contributor
There was a problem hiding this comment.
Also, there's a missing word - should be "converted into a package"
Member
Author
|
Thank you @ncoghlan for your review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test.test_support module was converted into package and renamed
to test.support. The test.script_helper module was moved into
the test.support package. Names test.test_support and
test.script_helper are left as aliases to test.support and
test.support.script_helper.