Skip to content

[3.10] gh-135034: Normalize link targets in tarfile, add os.path.realpath(strict='allow_missing') (GH-135037) #135070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ambv merged 13 commits into from
Jun 3, 2025
Merged

[3.10] gh-135034: Normalize link targets in tarfile, add os.path.realpath(strict='allow_missing') (GH-135037) #135070

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
4d959a0
[3.10] gh-135034: Normalize link targets in tarfile, add `os.path.rea…
ambv Jun 3, 2025
7c3e0dd
Drop the use of :cve:, which isn't supported in 3.11 and earlier.
Yhg1s Jun 3, 2025
9a46249
Merge branch '3.10' into backport-371b4ea-3.10
Yhg1s Jun 3, 2025
4afe368
Merge branch '3.10' into backport-371b4ea-3.10
Yhg1s Jun 3, 2025
aa526c0
Undo faulty merge.
Yhg1s Jun 3, 2025
6b6a77a
Fix test_tarfile (for not exporting LinkFallbackError) and remove the
Yhg1s Jun 3, 2025
0aaaeaa
Fix Windows test_ntpath failures.
Yhg1s Jun 3, 2025
05d7906
Fix merge error in backport.
Yhg1s Jun 3, 2025
ad7b73d
Remove backported tests that won't pass in 3.10 and earlier for reasons
Yhg1s Jun 3, 2025
bf6b637
Fix merge error.
Yhg1s Jun 3, 2025
dff62a1
Work around Path.glob() failure in 3.10
encukou Jun 3, 2025
720038b
Complete the backport of ALLOW_MISSING
encukou Jun 3, 2025
bacf333
Remove tests for WASI
encukou Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test_tarfile (for not exporting LinkFallbackError) and remove the 
non-strict test for unreadable symlinks, whch isn't supported before 3.13.
  • Loading branch information
@Yhg1s
Yhg1s committed Jun 3, 2025
commit 6b6a77a066d37ce6643eef7bfdf0ff376a3d5f45
16 changes: 0 additions & 16 deletions Lib/test/test_posixpath.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -707,22 +707,6 @@ def test_realpath_resolve_first(self, kwargs):
safe_rmdir(ABSTFN + "/k")
safe_rmdir(ABSTFN)

@os_helper.skip_unless_symlink
@skip_if_ABSTFN_contains_backslash
@unittest.skipIf(os.chmod not in os.supports_follow_symlinks, "Can't set symlink permissions")
@unittest.skipIf(sys.platform != "darwin", "only macOS requires read permission to readlink()")
def test_realpath_unreadable_symlink(self):
try:
os.symlink(ABSTFN+"1", ABSTFN)
os.chmod(ABSTFN, 0o000, follow_symlinks=False)
self.assertEqual(realpath(ABSTFN), ABSTFN)
self.assertEqual(realpath(ABSTFN + '/foo'), ABSTFN + '/foo')
self.assertEqual(realpath(ABSTFN + '/../foo'), dirname(ABSTFN) + '/foo')
self.assertEqual(realpath(ABSTFN + '/foo/..'), ABSTFN)
finally:
os.chmod(ABSTFN, 0o755, follow_symlinks=False)
os_helper.unlink(ABSTFN)

@os_helper.skip_unless_symlink
@skip_if_ABSTFN_contains_backslash
@unittest.skipIf(os.chmod not in os.supports_follow_symlinks, "Can't set symlink permissions")
Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_tarfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2461,7 +2461,7 @@ def test__all__(self):
"fully_trusted_filter", "data_filter",
"tar_filter", "FilterError", "AbsoluteLinkError",
"OutsideDestinationError", "SpecialFileError", "AbsolutePathError",
"LinkOutsideDestinationError",
"LinkOutsideDestinationError", "LinkFallbackError",
}
support.check__all__(self, tarfile, not_exported=not_exported)

Expand Down
Loading