Ensure that zipfile._Extra.split is polymorphic#134999
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
The instruction says:
I think this fix is obvious and trivial enough that an extra issue is overkill. |
|
We need issues for actual bugs. They aren't needed for things like documentation changes. |
|
I don't know what should be put in the issue body. The original code is a bad design and may cause an issue if someone extends the |
Not disagreeing, but in practice, people will just fix that on the fly. It's typically not worth it to prematurely fix internal APIs. I'm going to leave this one up to @jaraco who wrote the code. |
zipfile._Extra.splitzipfile._Extra.split is polymorphic
|
Closing, no issue has been created. |
|
@jaraco Did you intend to write the code in this way? Is there any special reason? It looks like a mistake, and if it really is, I can raise an issue and PR for it. |
As a class method, it should call from
clsinstead of_Extra.