Skip to content

Ensure that zipfile._Extra.split is polymorphic#134999

Closed
danny0838 wants to merge 1 commit into
python:mainfrom
danny0838:fix-zipfile-extra
Closed

Ensure that zipfile._Extra.split is polymorphic#134999
danny0838 wants to merge 1 commit into
python:mainfrom
danny0838:fix-zipfile-extra

Conversation

@danny0838

Copy link
Copy Markdown
Contributor

As a class method, it should call from cls instead of _Extra.

@bedevere-app

bedevere-app Bot commented Jun 1, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@ZeroIntensity ZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make an issue.

@danny0838

Copy link
Copy Markdown
Contributor Author

The instruction says:

Trivial changes, like fixing a typo, do not need an issue.

I think this fix is obvious and trivial enough that an extra issue is overkill.

@ZeroIntensity

Copy link
Copy Markdown
Member

We need issues for actual bugs. They aren't needed for things like documentation changes.

@danny0838

danny0838 commented Jun 3, 2025

Copy link
Copy Markdown
Contributor Author

I don't know what should be put in the issue body.

The original code is a bad design and may cause an issue if someone extends the _Extra class, but it does not cause an actual bug so far as _Extra is only used internally.

@ZeroIntensity

Copy link
Copy Markdown
Member

The original code is a bad design and may cause an issue if someone extends the _Extra class, but it does not cause an actual bug so far as _Extra is only used internally.

Not disagreeing, but in practice, people will just fix that on the fly. It's typically not worth it to prematurely fix internal APIs.

I'm going to leave this one up to @jaraco who wrote the code.

@StanFromIreland StanFromIreland added the pending The issue will be closed if no feedback is provided label Sep 6, 2025
@picnixz picnixz changed the title Fix zipfile._Extra.split Ensure that zipfile._Extra.split is polymorphic Sep 6, 2025
@picnixz picnixz requested a review from jaraco September 6, 2025 14:05
@StanFromIreland

Copy link
Copy Markdown
Member

Closing, no issue has been created.

@danny0838

danny0838 commented Feb 23, 2026

Copy link
Copy Markdown
Contributor Author

@jaraco Did you intend to write the code in this way? Is there any special reason?

It looks like a mistake, and if it really is, I can raise an issue and PR for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review pending The issue will be closed if no feedback is provided

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants