Skip to content

gh-124397: Add threading.iter_locked #133908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eendebakpt wants to merge 13 commits into
base: main
Choose a base branch
from
Open

gh-124397: Add threading.iter_locked #133908

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
6313b3d
Add iter_locked
eendebakpt May 10, 2025
5ced0a9
cleanup
eendebakpt May 11, 2025
110332e
cleanup
eendebakpt May 11, 2025
b675631
📜🤖 Added by blurb_it.
blurb-it[bot] May 11, 2025
4406050
update docs
eendebakpt May 12, 2025
d30ace8
review comments
eendebakpt Jun 1, 2025
baec5bc
use explicit lock
eendebakpt Jun 1, 2025
e6ea285
Merge branch 'main' into iter_locked
eendebakpt Jun 1, 2025
7315c49
fix import
eendebakpt Jun 1, 2025
b7c9d77
cleanup after merge to main
eendebakpt Jun 1, 2025
bb98c52
reduce duration of test
eendebakpt Jun 1, 2025
946ee51
use recursive lock
eendebakpt Jul 9, 2025
7e3653a
Merge branch 'main' into iter_locked
eendebakpt Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
reduce duration of test
  • Loading branch information
@eendebakpt
eendebakpt committed Jun 1, 2025
commit bb98c5213ed745303d7b6ce80ed2a678bf626a59
6 changes: 4 additions & 2 deletions Lib/test/test_free_threading/test_threading_iter_locked.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ def __iter__(self):

def __next__(self):
a = next(self.it)
time.sleep(0)
t = time.perf_counter() + 1e-6
while time.perf_counter() < t:
pass
b = next(self.it)
Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add time.sleep(0) (or with small non-zero argument) or Event.wait() with a timeout to force or significantly increase the chance of concurrent access.

return a, b

Expand All @@ -31,7 +33,7 @@ class iter_lockedThreading(unittest.TestCase):
@threading_helper.reap_threads
def test_iter_locked(self):
number_of_threads = 10
number_of_iterations = 10
number_of_iterations = 8
barrier = Barrier(number_of_threads)
def work(it):
while True:
Expand Down
Loading