Skip to content

gh-133968: Use private unicode writer for json #133832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 11 commits into from
May 31, 2025
Merged

gh-133968: Use private unicode writer for json #133832

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9ea12ad
Use private unicode writer for json
nineteendo May 10, 2025
46df04f
Part 2
nineteendo May 10, 2025
ab1aa42
Restore fast path for integers
nineteendo May 10, 2025
d18c455
Reduce diff
nineteendo May 10, 2025
51c760f
Include necessary headers
nineteendo May 10, 2025
72ae3d0
Use PyUnicodeWriter_WriteRepr
nineteendo May 10, 2025
2a6ec43
Reduce diff
nineteendo May 13, 2025
49a92f3
Merge branch 'main' into json-private-unicode-writer
nineteendo May 13, 2025
822ea86
Reduce diff
nineteendo May 13, 2025
01c45a9
Avoid heap allocation
nineteendo May 15, 2025
566637c
Merge branch 'main' into json-private-unicode-writer
nineteendo May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Reduce diff
  • Loading branch information
@nineteendo
nineteendo committed May 10, 2025
commit d18c455e12f7bcc83210d20b63accab90583e354
1 change: 1 addition & 0 deletions Modules/_json.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1483,7 +1483,8 @@
}
else if (PyLong_Check(obj)) {
if (PyLong_CheckExact(obj)) {
// Fast-path for exact integers
return _PyLong_FormatWriter(writer, obj, 10, 0);

Check failure on line 1487 in Modules/_json.c

View workflow job for this annotation

GitHub Actions / Hypothesis tests on Ubuntu 

implicit declaration of function ‘_PyLong_FormatWriter’; did you mean ‘_PyLong_FromDigits’? [-Werror=implicit-function-declaration]

Check failure on line 1487 in Modules/_json.c

View workflow job for this annotation

GitHub Actions / Ubuntu (bolt) / build and test (ubuntu-24.04) 

implicit declaration of function ‘_PyLong_FormatWriter’; did you mean ‘_PyLong_FromDigits’? [-Werror=implicit-function-declaration]

Check failure on line 1487 in Modules/_json.c

View workflow job for this annotation

GitHub Actions / Cross build Linux 

implicit declaration of function ‘_PyLong_FormatWriter’; did you mean ‘_PyLong_FromDigits’? [-Werror=implicit-function-declaration]

Check failure on line 1487 in Modules/_json.c

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04-arm) 

implicit declaration of function ‘_PyLong_FormatWriter’; did you mean ‘_PyLong_FromDigits’? [-Werror=implicit-function-declaration]

Check failure on line 1487 in Modules/_json.c

View workflow job for this annotation

GitHub Actions / Address sanitizer (ubuntu-24.04) 

implicit declaration of function ‘_PyLong_FormatWriter’; did you mean ‘_PyLong_FromDigits’? [-Werror=implicit-function-declaration]

Check failure on line 1487 in Modules/_json.c

View workflow job for this annotation

GitHub Actions / Ubuntu (free-threading) / build and test (ubuntu-24.04) 

implicit declaration of function ‘_PyLong_FormatWriter’; did you mean ‘_PyLong_FromDigits’? [-Werror=implicit-function-declaration]

Check failure on line 1487 in Modules/_json.c

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04) 

implicit declaration of function ‘_PyLong_FormatWriter’; did you mean ‘_PyLong_FromDigits’? [-Werror=implicit-function-declaration]

Check failure on line 1487 in Modules/_json.c

View workflow job for this annotation

GitHub Actions / Ubuntu (free-threading) / build and test (ubuntu-24.04-arm) 

implicit declaration of function ‘_PyLong_FormatWriter’; did you mean ‘_PyLong_FromDigits’? [-Werror=implicit-function-declaration]

Check warning on line 1487 in Modules/_json.c

View workflow job for this annotation

GitHub Actions / Windows / Build and test (x64) 

'_PyLong_FormatWriter' undefined; assuming extern returning int [D:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]

Check warning on line 1487 in Modules/_json.c

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / Build and test (x64) 

'_PyLong_FormatWriter' undefined; assuming extern returning int [D:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]

Check warning on line 1487 in Modules/_json.c

View workflow job for this annotation

GitHub Actions / Windows / Build and test (arm64) 

'_PyLong_FormatWriter' undefined; assuming extern returning int [C:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]

Check warning on line 1487 in Modules/_json.c

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / Build and test (arm64) 

'_PyLong_FormatWriter' undefined; assuming extern returning int [C:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]
}
PyObject *encoded = PyLong_Type.tp_repr(obj);
if (encoded == NULL)
Expand Down
Loading