review comments

python · iritkatriel · May 5, 2025 · Apr 24, 2025 · Apr 28, 2025 · Apr 29, 2025
commit f42d42f37fa27b9ca39814d2d855c1783369c25d
diff --git a/Modules/arraymodule.c b/Modules/arraymodule.c
@@ -3324,6 +3324,7 @@ array_modexec(PyObject *m)
     if (PyModule_Add(m, "typecodes", typecodes) < 0) {
         return -1;
     }
+
     return 0;
 }
 

diff --git a/Python/specialize.c b/Python/specialize.c
@@ -2572,17 +2572,18 @@ binary_op_extended_specialization(PyObject *lhs, PyObject *rhs, int oparg,
         }
     }
 
-    if (Py_TYPE(lhs)->tp_binop_specialize != NULL) {
-        int ret = Py_TYPE(lhs)->tp_binop_specialize(lhs, rhs, oparg, descr);
+    PyTypeObject *lhs_type = Py_TYPE(lhs);
+    if (lhs_type->tp_binop_specialize != NULL) {
+        int ret = lhs_type->tp_binop_specialize(lhs, rhs, oparg, descr);
         if (ret < 0) {
             return -1;
         }
         if (ret == 1) {
             if (*descr == NULL) {
                 PyErr_Format(
                     PyExc_ValueError,
-                    "tp_binop_specialize of '%.200s' returned 1 with *descr == NULL",
-                    Py_TYPE(lhs)->tp_name);
+                    "tp_binop_specialize of '%T' returned 1 with *descr == NULL",
+                    lhs_type->tp_name);
                 return -1;
             }
             (*descr)->oparg = oparg;
-Original file line number
+Diff line change
@@ Expand Up / @@ -3324,6 +3324,7 @@ array_modexec(PyObject *m) @@
         if (PyModule_Add(m, "typecodes", typecodes) < 0) {
             return -1;
         }
         return 0;
     }
@@ Expand Down @@