Skip to content

GH-132983: Build _zstd on Windows #133366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AA-Turner merged 7 commits into from
May 5, 2025
Merged

GH-132983: Build _zstd on Windows #133366

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2563adf
Sorting
AA-Turner May 4, 2025
93c78cc
Add Zstandard projects
AA-Turner May 4, 2025
a0cfc5d
Zstandard scaffold
AA-Turner May 4, 2025
b9208b6
Add dependency of _zstd to python
AA-Turner May 5, 2025
755919f
Combine zstd.vcxproj into _zstd.vcxproj
AA-Turner May 5, 2025
17149df
Rename `Modules\zdict.c` to `zstddict.c`
AA-Turner May 5, 2025
1ae3a76
Point $(zstdDir) to the root
AA-Turner May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add Zstandard projects
  • Loading branch information
@AA-Turner
AA-Turner committed May 4, 2025
commit 93c78cc86f7e6af6d0045aa9e547dcb92b0fd13d
126 changes: 126 additions & 0 deletions PCbuild/_zstd.vcxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,126 @@
<?xml version="1.0" encoding="utf-8"?>
<Project DefaultTargets="Build" ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<ItemGroup Label="ProjectConfigurations">
<ProjectConfiguration Include="Debug|ARM">
<Configuration>Debug</Configuration>
<Platform>ARM</Platform>
</ProjectConfiguration>
<ProjectConfiguration Include="Debug|ARM64">
<Configuration>Debug</Configuration>
<Platform>ARM64</Platform>
</ProjectConfiguration>
<ProjectConfiguration Include="Debug|Win32">
<Configuration>Debug</Configuration>
<Platform>Win32</Platform>
</ProjectConfiguration>
<ProjectConfiguration Include="Debug|x64">
<Configuration>Debug</Configuration>
<Platform>x64</Platform>
</ProjectConfiguration>
<ProjectConfiguration Include="PGInstrument|ARM">
<Configuration>PGInstrument</Configuration>
<Platform>ARM</Platform>
</ProjectConfiguration>
<ProjectConfiguration Include="PGInstrument|ARM64">
<Configuration>PGInstrument</Configuration>
<Platform>ARM64</Platform>
</ProjectConfiguration>
<ProjectConfiguration Include="PGInstrument|Win32">
<Configuration>PGInstrument</Configuration>
<Platform>Win32</Platform>
</ProjectConfiguration>
<ProjectConfiguration Include="PGInstrument|x64">
<Configuration>PGInstrument</Configuration>
<Platform>x64</Platform>
</ProjectConfiguration>
<ProjectConfiguration Include="PGUpdate|ARM">
<Configuration>PGUpdate</Configuration>
<Platform>ARM</Platform>
</ProjectConfiguration>
<ProjectConfiguration Include="PGUpdate|ARM64">
<Configuration>PGUpdate</Configuration>
<Platform>ARM64</Platform>
</ProjectConfiguration>
<ProjectConfiguration Include="PGUpdate|Win32">
<Configuration>PGUpdate</Configuration>
<Platform>Win32</Platform>
</ProjectConfiguration>
<ProjectConfiguration Include="PGUpdate|x64">
<Configuration>PGUpdate</Configuration>
<Platform>x64</Platform>
</ProjectConfiguration>
<ProjectConfiguration Include="Release|ARM">
<Configuration>Release</Configuration>
<Platform>ARM</Platform>
</ProjectConfiguration>
<ProjectConfiguration Include="Release|ARM64">
<Configuration>Release</Configuration>
<Platform>ARM64</Platform>
</ProjectConfiguration>
<ProjectConfiguration Include="Release|Win32">
<Configuration>Release</Configuration>
<Platform>Win32</Platform>
</ProjectConfiguration>
<ProjectConfiguration Include="Release|x64">
<Configuration>Release</Configuration>
<Platform>x64</Platform>
</ProjectConfiguration>
</ItemGroup>
<PropertyGroup Label="Globals">
<ProjectGuid>{07029b86-f3e9-443e-86fb-78aa6d47fed1}</ProjectGuid>
<RootNamespace>zstd</RootNamespace>
<Keyword>Win32Proj</Keyword>
</PropertyGroup>
<Import Project="python.props" />
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.Default.props" />
<PropertyGroup Label="Configuration">
<ConfigurationType>DynamicLibrary</ConfigurationType>
<CharacterSet>NotSet</CharacterSet>
</PropertyGroup>
<PropertyGroup Label="Configuration" />
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.props" />
<PropertyGroup>
<TargetExt>$(PyStdlibPydExt)</TargetExt>
</PropertyGroup>
<ImportGroup Label="ExtensionSettings">
</ImportGroup>
<ImportGroup Label="PropertySheets">
<Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
<Import Project="pyproject.props" />
</ImportGroup>
<PropertyGroup Label="UserMacros" />
<PropertyGroup>
<_ProjectFileVersion>10.0.30319.1</_ProjectFileVersion>
</PropertyGroup>
<ItemDefinitionGroup>
<ClCompile>
<AdditionalIncludeDirectories>$(zstdDir);%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
</ClCompile>
</ItemDefinitionGroup>
<ItemGroup>
<ClCompile Include="..\Modules\_zstd\_zstdmodule.c" />
<ClCompile Include="..\Modules\_zstd\compressor.c" />
<ClCompile Include="..\Modules\_zstd\decompressor.c" />
<ClCompile Include="..\Modules\_zstd\zdict.c" />
</ItemGroup>
<ItemGroup>
<ClInclude Include="..\Modules\_zstd\_zstdmodule.h" />
<ClInclude Include="..\Modules\_zstd\buffer.h" />
</ItemGroup>
<ItemGroup>
<ResourceCompile Include="..\PC\python_nt.rc" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="pythoncore.vcxproj">
<Project>{cf7ac3d1-e2df-41d2-bea6-1e2556cdea26}</Project>
<ReferenceOutputAssembly>false</ReferenceOutputAssembly>
</ProjectReference>
<ProjectReference Include="zstd.vcxproj">
<Project>{8d80e018-6a7d-4b46-a7be-d9e02a20d473}</Project>
<ReferenceOutputAssembly>false</ReferenceOutputAssembly>
</ProjectReference>
</ItemGroup>
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
<ImportGroup Label="ExtensionTargets">
</ImportGroup>
</Project>
41 changes: 41 additions & 0 deletions PCbuild/_zstd.vcxproj.filters
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<ItemGroup>
<Filter Include="Source Files">
<UniqueIdentifier>{4FC737F1-C7A5-4376-A066-2A32D752A2FF}</UniqueIdentifier>
</Filter>
<Filter Include="Header Files">
<UniqueIdentifier>{93995380-89BD-4b04-88EB-625FBE52EBFB}</UniqueIdentifier>
</Filter>
<Filter Include="Resource Files">
<UniqueIdentifier>{67DA6AB6-F800-4c08-8B7A-83BB121AAD01}</UniqueIdentifier>
</Filter>
</ItemGroup>
<ItemGroup>
<ClCompile Include="..\Modules\_zstd\_zstdmodule.c">
<Filter>Source Files</Filter>
</ClCompile>
<ClCompile Include="..\Modules\_zstd\compressor.c">
<Filter>Source Files</Filter>
</ClCompile>
<ClCompile Include="..\Modules\_zstd\decompressor.c">
<Filter>Source Files</Filter>
</ClCompile>
<ClCompile Include="..\Modules\_zstd\zdict.c">
<Filter>Source Files</Filter>
</ClCompile>
</ItemGroup>
<ItemGroup>
<ClInclude Include="..\Modules\_zstd\_zstdmodule.h">
<Filter>Header Files</Filter>
</ClInclude>
<ClInclude Include="..\Modules\_zstd\buffer.h">
<Filter>Header Files</Filter>
</ClInclude>
</ItemGroup>
<ItemGroup>
<ResourceCompile Include="..\PC\python_nt.rc">
<Filter>Resource Files</Filter>
</ResourceCompile>
</ItemGroup>
</Project>
158 changes: 158 additions & 0 deletions PCbuild/zstd.vcxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,158 @@
<?xml version="1.0" encoding="utf-8"?>
<Project DefaultTargets="Build" ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<ItemGroup Label="ProjectConfigurations">
<ProjectConfiguration Include="Debug|ARM">
<Configuration>Debug</Configuration>
<Platform>ARM</Platform>
</ProjectConfiguration>
<ProjectConfiguration Include="Debug|ARM64">
<Configuration>Debug</Configuration>
<Platform>ARM64</Platform>
</ProjectConfiguration>
<ProjectConfiguration Include="Debug|Win32">
<Configuration>Debug</Configuration>
<Platform>Win32</Platform>
</ProjectConfiguration>
<ProjectConfiguration Include="PGInstrument|ARM">
<Configuration>PGInstrument</Configuration>
<Platform>ARM</Platform>
</ProjectConfiguration>
<ProjectConfiguration Include="PGUpdate|ARM">
<Configuration>PGUpdate</Configuration>
<Platform>ARM</Platform>
</ProjectConfiguration>
<ProjectConfiguration Include="Release|ARM">
<Configuration>Release</Configuration>
<Platform>ARM</Platform>
</ProjectConfiguration>
<ProjectConfiguration Include="PGInstrument|ARM64">
<Configuration>PGInstrument</Configuration>
<Platform>ARM64</Platform>
</ProjectConfiguration>
<ProjectConfiguration Include="PGUpdate|ARM64">
<Configuration>PGUpdate</Configuration>
<Platform>ARM64</Platform>
</ProjectConfiguration>
<ProjectConfiguration Include="Release|ARM64">
<Configuration>Release</Configuration>
<Platform>ARM64</Platform>
</ProjectConfiguration>
<ProjectConfiguration Include="Release|Win32">
<Configuration>Release</Configuration>
<Platform>Win32</Platform>
</ProjectConfiguration>
<ProjectConfiguration Include="PGInstrument|Win32">
<Configuration>PGInstrument</Configuration>
<Platform>Win32</Platform>
</ProjectConfiguration>
<ProjectConfiguration Include="PGInstrument|x64">
<Configuration>PGInstrument</Configuration>
<Platform>x64</Platform>
</ProjectConfiguration>
<ProjectConfiguration Include="PGUpdate|Win32">
<Configuration>PGUpdate</Configuration>
<Platform>Win32</Platform>
</ProjectConfiguration>
<ProjectConfiguration Include="PGUpdate|x64">
<Configuration>PGUpdate</Configuration>
<Platform>x64</Platform>
</ProjectConfiguration>
<ProjectConfiguration Include="Debug|x64">
<Configuration>Debug</Configuration>
<Platform>x64</Platform>
</ProjectConfiguration>
<ProjectConfiguration Include="Release|x64">
<Configuration>Release</Configuration>
<Platform>x64</Platform>
</ProjectConfiguration>
</ItemGroup>
<PropertyGroup Label="Globals">
<ProjectGuid>{8d80e018-6a7d-4b46-a7be-d9e02a20d473}</ProjectGuid>
<RootNamespace>zstd</RootNamespace>
<SupportPGO>true</SupportPGO>
</PropertyGroup>

<Import Project="python.props" />
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.Default.props" />

<PropertyGroup Label="Configuration">
<ConfigurationType>StaticLibrary</ConfigurationType>
</PropertyGroup>
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.props" />
<ImportGroup Label="ExtensionSettings">
</ImportGroup>
<ImportGroup Label="PropertySheets">
<Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
<Import Project="pyproject.props" />
</ImportGroup>
<PropertyGroup Label="UserMacros" />
<PropertyGroup>
<_ProjectFileVersion>10.0.30319.1</_ProjectFileVersion>
</PropertyGroup>
<ItemDefinitionGroup>
<ClCompile>
<PreprocessorDefinitions>WIN32;ZSTD_MULTITHREAD=1;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<AdditionalIncludeDirectories>$(zstdDir);$(zstdDir)common;$(zstdDir)dictBuilder;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
</ClCompile>
</ItemDefinitionGroup>
<ItemGroup>
<ClCompile Include="$(zstdDir)common\debug.c" />
<ClCompile Include="$(zstdDir)common\entropy_common.c" />
<ClCompile Include="$(zstdDir)common\error_private.c" />
<ClCompile Include="$(zstdDir)common\fse_decompress.c" />
<ClCompile Include="$(zstdDir)common\pool.c" />
<ClCompile Include="$(zstdDir)common\threading.c" />
<ClCompile Include="$(zstdDir)common\xxhash.c" />
<ClCompile Include="$(zstdDir)common\zstd_common.c" />
<ClCompile Include="$(zstdDir)compress\fse_compress.c" />
<ClCompile Include="$(zstdDir)compress\hist.c" />
<ClCompile Include="$(zstdDir)compress\huf_compress.c" />
<ClCompile Include="$(zstdDir)compress\zstd_compress.c" />
<ClCompile Include="$(zstdDir)compress\zstd_compress_literals.c" />
<ClCompile Include="$(zstdDir)compress\zstd_compress_sequences.c" />
<ClCompile Include="$(zstdDir)compress\zstd_compress_superblock.c" />
<ClCompile Include="$(zstdDir)compress\zstd_double_fast.c" />
<ClCompile Include="$(zstdDir)compress\zstd_fast.c" />
<ClCompile Include="$(zstdDir)compress\zstd_lazy.c" />
<ClCompile Include="$(zstdDir)compress\zstd_ldm.c" />
<ClCompile Include="$(zstdDir)compress\zstd_opt.c" />
<ClCompile Include="$(zstdDir)compress\zstd_preSplit.c" />
<ClCompile Include="$(zstdDir)compress\zstdmt_compress.c" />
<ClCompile Include="$(zstdDir)decompress\huf_decompress.c" />
<ClCompile Include="$(zstdDir)decompress\zstd_ddict.c" />
<ClCompile Include="$(zstdDir)decompress\zstd_decompress.c" />
<ClCompile Include="$(zstdDir)decompress\zstd_decompress_block.c" />
<ClCompile Include="$(zstdDir)dictBuilder\cover.c" />
<ClCompile Include="$(zstdDir)dictBuilder\divsufsort.c" />
<ClCompile Include="$(zstdDir)dictBuilder\fastcover.c" />
<ClCompile Include="$(zstdDir)dictBuilder\zdict.c" />
</ItemGroup>
<ItemGroup>
<ClInclude Include="$(zstdDir)common\bitstream.h" />
<ClInclude Include="$(zstdDir)common\error_private.h" />
<ClInclude Include="$(zstdDir)common\fse.h" />
<ClInclude Include="$(zstdDir)common\huf.h" />
<ClInclude Include="$(zstdDir)common\mem.h" />
<ClInclude Include="$(zstdDir)common\pool.h" />
<ClInclude Include="$(zstdDir)common\threading.h" />
<ClInclude Include="$(zstdDir)common\xxhash.h" />
<ClInclude Include="$(zstdDir)common\zstd_internal.h" />
<ClInclude Include="$(zstdDir)compress\zstd_compress.h" />
<ClInclude Include="$(zstdDir)compress\zstd_compress_literals.h" />
<ClInclude Include="$(zstdDir)compress\zstd_compress_sequences.h" />
<ClInclude Include="$(zstdDir)compress\zstd_compress_superblock.h" />
<ClInclude Include="$(zstdDir)compress\zstd_cwksp.h" />
<ClInclude Include="$(zstdDir)compress\zstd_double_fast.h" />
<ClInclude Include="$(zstdDir)compress\zstd_fast.h" />
<ClInclude Include="$(zstdDir)compress\zstd_lazy.h" />
<ClInclude Include="$(zstdDir)compress\zstd_ldm.h" />
<ClInclude Include="$(zstdDir)compress\zstd_opt.h" />
<ClInclude Include="$(zstdDir)compress\zstdmt_compress.h" />
<ClInclude Include="$(zstdDir)decompress\zstd_ddict.h" />
<ClInclude Include="$(zstdDir)zstd.h" />
<ClInclude Include="$(zstdDir)zstd_errors.h" />
</ItemGroup>
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
<ImportGroup Label="ExtensionTargets">
</ImportGroup>
</Project>
Loading