Skip to content

gh-135336: Add fast path to json string encoding #133239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 13 commits into from
Aug 7, 2025
Merged

gh-135336: Add fast path to json string encoding #133239

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
930e938
Fast path for string encoding
nineteendo May 1, 2025
32eefb3
Merge branch 'main' into speedup-json-encode
nineteendo May 13, 2025
078965b
Merge branch 'main' into speedup-json-encode
nineteendo May 30, 2025
83499a4
Improve slow path
nineteendo May 30, 2025
25da453
Reduce diff
nineteendo May 30, 2025
b4a8026
Reduce diff
nineteendo Jun 10, 2025
8ee4c93
Reuse code
nineteendo Jun 10, 2025
7b055be
Fix compiler warnings
nineteendo Jun 10, 2025
660d962
📜🤖 Added by blurb_it.
blurb-it[bot] Jun 11, 2025
19f252a
Improve fast path
nineteendo Jun 12, 2025
c4feeb9
Merge branch 'main' into speedup-json-encode
serhiy-storchaka Jul 28, 2025
b12d42d
Address review
nineteendo Jul 28, 2025
1a035c9
Apply suggestions from code review
vstinner Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Reduce diff
  • Loading branch information
@nineteendo
nineteendo committed Jun 10, 2025
commit b4a802674bb4ae892109c6ec3af728f6938f81a5
2 changes: 1 addition & 1 deletion Modules/_json.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1805,7 +1805,7 @@ encoder_encode_key_value(PyEncoderObject *s, PyUnicodeWriter *writer, bool *firs
Py_DECREF(keystr);

if (rv < 0) {
return rv;
return -1;
}
if (PyUnicodeWriter_WriteStr(writer, s->key_separator) < 0) {
return -1;
Expand Down
Loading