Skip to content

gh-133197: Improve error message for ft"" and bt"" cases #133202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sobolevn merged 4 commits into from
Apr 30, 2025
Merged

gh-133197: Improve error message for ft"" and bt"" cases #133202

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4f57f3d
gh-133196: Improve error message for `ft""` case
sobolevn Apr 30, 2025
b269ebb
Also handle `tb` cases
sobolevn Apr 30, 2025
40668a5
Address review
sobolevn Apr 30, 2025
a4aa4c0
together
sobolevn Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
gh-133196: Improve error message for ft"" case
  • Loading branch information
@sobolevn
sobolevn committed Apr 30, 2025
commit 4f57f3df6fc63f24e3099dfbfc85e07259a6123a
9 changes: 9 additions & 0 deletions Lib/test/test_syntax.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1877,6 +1877,15 @@
Traceback (most recent call last):
SyntaxError: cannot assign to f-string expression here. Maybe you meant '==' instead of '='?

>>> ft'abc'
Traceback (most recent call last):
SyntaxError: can't use 'f' and 't' string prefixes at the same time

>>> x = 1
Comment thread
sobolevn marked this conversation as resolved.
Outdated
>>> tf"{x=}"
Traceback (most recent call last):
SyntaxError: can't use 'f' and 't' string prefixes at the same time

>>> t'{x}' = 42
Traceback (most recent call last):
SyntaxError: cannot assign to t-string expression here. Maybe you meant '==' instead of '='?
Expand Down
9 changes: 7 additions & 2 deletions Parser/lexer/lexer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -660,17 +660,22 @@ tok_get_normal_mode(struct tok_state *tok, tokenizer_mode* current_tok, struct t
else if (!(saw_r || saw_u) && (c == 'r' || c == 'R')) {
saw_r = 1;
}
else if (!(saw_f || saw_b || saw_u || saw_t) && (c == 'f' || c == 'F')) {
else if (!(saw_f || saw_b || saw_u) && (c == 'f' || c == 'F')) {
saw_f = 1;
}
else if (!(saw_t || saw_b || saw_u || saw_f) && (c == 't' || c == 'T')) {
else if (!(saw_t || saw_b || saw_u) && (c == 't' || c == 'T')) {
saw_t = 1;
}
else {
break;
}
c = tok_nextc(tok);
if (c == '"' || c == '\'') {
if (saw_f && saw_t) {
return MAKE_TOKEN(_PyTokenizer_syntaxerror(
tok,
"can't use 'f' and 't' string prefixes at the same time"));
}
if (saw_f || saw_t) {
goto f_string_quote;
}
Expand Down
Loading