[3.13] Revert "[3.13] gh-132921: Fix setuptools._distutils.dep_util deprecation (GH-132923) (#132926)"#133004
Merged
Merged
Conversation
…precation (pythonGH-132923) (python#132926)" This reverts commit 3776ade. setuptools.modified module is not available on old setuptools versions.
Member
Author
|
Python 3.13 uses setuptools-67.6.1 which doesn't have |
Contributor
|
Hi @vstinner, do you plan to backport this change in a different way? Because while Internally, I went with the following; it should work with both old and new: --- Python-3.13.3/Tools/peg_generator/pegen/build.py
+++ Python-3.13.3/Tools/peg_generator/pegen/build.py
@@ -95,7 +95,10 @@ def compile_c_extension(
import setuptools.logging
from setuptools import Extension, Distribution
- from setuptools._distutils.dep_util import newer_group
+ try:
+ from setuptools.modified import newer_group
+ except ImportError:
+ from setuptools._distutils.dep_util import newer_group
from setuptools._distutils.ccompiler import new_compiler
from setuptools._distutils.sysconfig import customize_compiler |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 3776ade.
setuptools.modified module is not available on old setuptools versions.