Skip to content

gh-123471: Make itertools.product and itertools.combinations thread-safe #132814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumaraditya303 merged 7 commits into from
Jun 30, 2025
Merged

gh-123471: Make itertools.product and itertools.combinations thread-safe #132814

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f20855c
Make itertools.product and itertools.combinations thread-safe
eendebakpt Apr 22, 2025
6f14bd0
📜🤖 Added by blurb_it.
blurb-it[bot] Apr 22, 2025
a204f6d
whitespace
eendebakpt Apr 22, 2025
cdfe7c2
Merge branch 'itertools_combinations_ft' of github.com:eendebakpt/cpy…
eendebakpt Apr 22, 2025
24c8f68
Merge branch 'main' into itertools_combinations_ft
eendebakpt Jun 18, 2025
7ab53c3
Merge branch 'main' into itertools_combinations_ft
kumaraditya303 Jun 25, 2025
ba9c4b7
Apply suggestions from code review
kumaraditya303 Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply suggestions from code review
  • Loading branch information
@kumaraditya303
kumaraditya303 authored Jun 30, 2025
commit ba9c4b7fdc9f86b77c0990f514d6206735ce8578
4 changes: 2 additions & 2 deletions Modules/itertoolsmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2175,7 +2175,7 @@ product_next_lock_held(PyObject *op)
static PyObject *
product_next(PyObject *op)
{
PyObject * result;
PyObject *result;
Py_BEGIN_CRITICAL_SECTION(op);
result = product_next_lock_held(op);
Py_END_CRITICAL_SECTION()
Expand Down Expand Up @@ -2417,7 +2417,7 @@ combinations_next_lock_held(PyObject *op)
static PyObject *
combinations_next(PyObject *op)
{
PyObject * result;
PyObject *result;
Py_BEGIN_CRITICAL_SECTION(op);
result = combinations_next_lock_held(op);
Py_END_CRITICAL_SECTION()
Expand Down
Loading