Skip to content

gh-127945: add test_ctypes to free-threading TSAN CI #132727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumaraditya303 merged 8 commits into from
Apr 21, 2025
Merged

gh-127945: add test_ctypes to free-threading TSAN CI #132727

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d1b4178
add test_ctypes to free-threading CI
kumaraditya303 Apr 19, 2025
1ad25cc
Merge branch 'main' into ci
kumaraditya303 Apr 21, 2025
c8f196d
verbose
kumaraditya303 Apr 21, 2025
6b94cc2
remove -j4
kumaraditya303 Apr 21, 2025
bf8a6cb
skip test_pointers
kumaraditya303 Apr 21, 2025
2fe21f0
wip
kumaraditya303 Apr 21, 2025
179d911
revert
kumaraditya303 Apr 21, 2025
da7f0e9
Update Lib/test/test_ctypes/test_as_parameter.py
kumaraditya303 Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
revert
  • Loading branch information
@kumaraditya303
kumaraditya303 committed Apr 21, 2025
commit 179d9113268b5f9f0527d8f52874f342eb40cc4c
2 changes: 1 addition & 1 deletion .github/workflows/reusable-tsan.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ jobs:
- name: Display build info
run: make pythoninfo
- name: Tests
run: ./python -m test --tsan -vv
run: ./python -m test --tsan -j4
- name: Parallel tests
if: fromJSON(inputs.free-threading)
run: ./python -m test --tsan-parallel --parallel-threads=4 -j4
Expand Down
56 changes: 28 additions & 28 deletions Lib/test/libregrtest/tsan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,35 +2,35 @@
# chosen because they use threads and run in a reasonable amount of time.

TSAN_TESTS = [
# 'test_asyncio',
# # TODO: enable more of test_capi once bugs are fixed (GH-116908, GH-116909).
# 'test_capi.test_mem',
# 'test_capi.test_pyatomic',
# 'test_code',
'test_asyncio',
# TODO: enable more of test_capi once bugs are fixed (GH-116908, GH-116909).
'test_capi.test_mem',
'test_capi.test_pyatomic',
'test_code',
'test_ctypes',
# # 'test_concurrent_futures', # gh-130605: too many data races
# 'test_enum',
# 'test_functools',
# 'test_httpservers',
# 'test_imaplib',
# 'test_importlib',
# 'test_io',
# 'test_logging',
# 'test_opcache',
# 'test_queue',
# 'test_signal',
# 'test_socket',
# 'test_sqlite3',
# 'test_ssl',
# 'test_syslog',
# 'test_thread',
# 'test_thread_local_bytecode',
# 'test_threadedtempfile',
# 'test_threading',
# 'test_threading_local',
# 'test_threadsignals',
# 'test_weakref',
# 'test_free_threading',
# 'test_concurrent_futures', # gh-130605: too many data races
'test_enum',
'test_functools',
'test_httpservers',
'test_imaplib',
'test_importlib',
'test_io',
'test_logging',
'test_opcache',
'test_queue',
'test_signal',
'test_socket',
'test_sqlite3',
'test_ssl',
'test_syslog',
'test_thread',
'test_thread_local_bytecode',
'test_threadedtempfile',
'test_threading',
'test_threading_local',
'test_threadsignals',
'test_weakref',
'test_free_threading',
]

# Tests that should be run with `--parallel-threads=N` under TSAN. These tests
Expand Down
3 changes: 1 addition & 2 deletions Lib/test/test_ctypes/test_as_parameter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ def test_wchar_parm(self):
self.assertEqual(result, 139)
self.assertIs(type(result), int)

@skip_if_sanitizer('thread', thread=True)
def test_pointers(self):
f = dll._testfunc_p_p
f.restype = POINTER(c_int)
Expand Down Expand Up @@ -193,7 +192,7 @@ class S8I(Structure):
self.assertEqual((s8i.a, s8i.b, s8i.c, s8i.d, s8i.e, s8i.f, s8i.g, s8i.h),
(9*2, 8*3, 7*4, 6*5, 5*6, 4*7, 3*8, 2*9))

@skip_if_sanitizer('thread', thread=True)
@skip_if_sanitizer('hangs on TSAN', thread=True)
Comment thread
kumaraditya303 marked this conversation as resolved.
Outdated
def test_recursive_as_param(self):
class A:
pass
Expand Down
Loading