Skip to content

gh-81793: Always call linkat() from os.link(), if available #132517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 13 commits into from
May 4, 2025
Merged

gh-81793: Always call linkat() from os.link(), if available #132517

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
a8f488a
gh-81793: Always call linkat() from os.link(), if available
serhiy-storchaka Apr 14, 2025
4ba224e
Fix typo and regenerate clinic files.
serhiy-storchaka Apr 14, 2025
5881b2a
Fix OpenIndiana.
serhiy-storchaka Apr 14, 2025
d2f233b
Fix test_inspect.
serhiy-storchaka Apr 14, 2025
95f55e3
Enable linkat().
serhiy-storchaka Apr 14, 2025
2eeb438
Apply suggestions from code review
serhiy-storchaka Apr 14, 2025
b4be526
Use subTest().
serhiy-storchaka Apr 15, 2025
80128e3
Disable linkat() on WASI.
serhiy-storchaka Apr 15, 2025
a45dfd9
Test how link() actually works on WASI.
serhiy-storchaka Apr 15, 2025
557f1ee
Revert "Test how link() actually works on WASI."
serhiy-storchaka Apr 15, 2025
b156f94
Merge branch 'main' into os-link-follow_symlinks
serhiy-storchaka Apr 21, 2025
2c436fb
Remove redundant checks for same type.
serhiy-storchaka Apr 21, 2025
0c7b16d
Merge branch 'main' into os-link-follow_symlinks
serhiy-storchaka May 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
  • Loading branch information
@serhiy-storchaka @StanFromIreland
serhiy-storchaka and StanFromIreland authored Apr 14, 2025
commit 2eeb438c1289ad5962b68ed21ec1b1f8724b0661
6 changes: 3 additions & 3 deletions Misc/NEWS.d/next/Library/2025-04-14-17-24-50.gh-issue-81793.OhRTTT.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Fix :func:`os.link` on platforms (like Linux) where the
system :c:func:`!link` function does not follow symlinks. On Linux,
it now follows symlinks by default and if
``follow_symlinks=True`` is specified. On Windows, it now raises error if
``follow_symlinks=True`` is passed. On macOS, it now raises error if
it now follows symlinks by default or if
``follow_symlinks=True`` is specified. On Windows, it now raises an error if
``follow_symlinks=True`` is passed. On macOS, it now raises an error if
``follow_symlinks=False`` is passed and the system :c:func:`!linkat`
function is not available at runtime.
2 changes: 1 addition & 1 deletion Modules/posixmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4362,7 +4362,7 @@ os_link_impl(PyObject *module, path_t *src, path_t *dst, int src_dir_fd,
argument_unavailable_error("link", "src_dir_fd and dst_dir_fd");
return NULL;
}
/* See issue 41355: link() on Linux works like linkat without AT_SYMLINK_FOLLOW,
/* See issue 85527: link() on Linux works like linkat without AT_SYMLINK_FOLLOW,
but on Mac it works like linkat *with* AT_SYMLINK_FOLLOW. */
#if defined(MS_WINDOWS) || defined(__linux__)
if (follow_symlinks == 1) {
Expand Down
Loading