Skip to content

gh-128398: improve error message when incorrectly with and async with #132218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
picnixz merged 13 commits into from
Apr 19, 2025
Merged

gh-128398: improve error message when incorrectly with and async with #132218

Changes from 2 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
aff8184
improve error messages when incorrectly using context managers
picnixz Apr 7, 2025
db1fcfc
Merge remote-tracking branch 'upstream/main' into feat/core/async-wit…
picnixz Apr 13, 2025
69dc81f
move tests
picnixz Apr 13, 2025
6fce800
restore file
picnixz Apr 13, 2025
a1303a4
reduce symbol visibility
picnixz Apr 18, 2025
7977866
Merge remote-tracking branch 'upstream/main' into feat/core/async-wit…
picnixz Apr 18, 2025
f77056e
fix typo
picnixz Apr 18, 2025
d617d89
Update Misc/NEWS.d/next/Core_and_Builtins/2025-04-07-13-46-57.gh-issu…
picnixz Apr 18, 2025
018e4ae
add What's New
picnixz Apr 18, 2025
1885e94
Merge branch 'feat/core/async-with-suggesetions-128398' of github.com…
picnixz Apr 18, 2025
bbf6d2e
Update Include/internal/pycore_ceval.h
picnixz Apr 18, 2025
34ad9a4
Update Include/internal/pycore_ceval.h
picnixz Apr 18, 2025
3597dd6
Merge branch 'main' into feat/core/async-with-suggesetions-128398
picnixz Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Misc/NEWS.d/next/Core_and_Builtins/2025-04-07-13-46-57.gh-issue-128398.gJ2zIF.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Improve error message when an object supporting the synchronous (resp.
asynchronous) context manager protocol is entered using :keyword:`async
with` (resp. :keyword:`with`) block instead of :keyword:`with` (resp.
with` (resp. :keyword:`with`) instead of :keyword:`with` (resp.
:keyword:`async with`). Patch by Bénédikt Tran.
Loading