bpo-36831: Do not apply default namespace to unprefixed attributes in ElementPath#13201
Merged
Merged
Conversation
zooba
approved these changes
May 8, 2019
Member
There was a problem hiding this comment.
Personally I'd use parsing_attribute here (and not parsing_attribute below), just because it's easier to read. But the logic looks fine to me
cf21476 to
39c6c9a
Compare
… ElementPath. Also provide better grouping of the tokenizer tests.
39c6c9a to
c097433
Compare
scoder
added a commit
to lxml/lxml
that referenced
this pull request
May 8, 2019
… unprefixed attribute names. Fix copied from python/cpython#13201
|
@scoder: Please replace |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also provide better grouping of the tokenizer tests.
https://bugs.python.org/issue36831