Skip to content

gh-111178: remove redundant casts for functions with correct signatures #131673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
picnixz merged 24 commits into from
Apr 1, 2025
Merged

gh-111178: remove redundant casts for functions with correct signatures #131673

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
70861ec
remove un-necessary casts to PyCFunction
picnixz Feb 6, 2025
d356465
remove un-necessary casts to `getter`
picnixz Feb 6, 2025
f641773
remove un-necessary casts to `setter`
picnixz Feb 6, 2025
a197210
remove un-necessary casts for `initproc`
picnixz Mar 20, 2025
5a39cb7
add TODO note to remove casts to `destructor`
picnixz Mar 20, 2025
222b662
un-necessary cast for module free functions
picnixz Mar 20, 2025
ad434c0
fixup: None and NoneType
picnixz Mar 20, 2025
2fea60f
fixup: _PyDictViewObject
picnixz Mar 20, 2025
47bc0ee
fixup: bool_invert
picnixz Mar 20, 2025
a894c4c
fixup: PyUnicodeObject methods
picnixz Mar 20, 2025
1c17bfc
fixup: rangeobject
picnixz Mar 20, 2025
e415739
fixup: zoneinfo_init_subclass
picnixz Mar 20, 2025
86bc47c
fixup: ga_iter
picnixz Mar 24, 2025
5d98a84
fixup: hamt_baseiter_tp_iternext
picnixz Mar 24, 2025
1053101
remove dead code
picnixz Mar 24, 2025
5e68e29
Merge branch 'main' into fix/ubsan/casts-111178
picnixz Mar 24, 2025
937aa63
Merge branch 'main' into fix/ubsan/casts-111178
picnixz Mar 24, 2025
9c780ad
Update Include/cpython/object.h
picnixz Mar 24, 2025
3124512
Merge remote-tracking branch 'upstream/main' into fix/ubsan/casts-111178
picnixz Mar 30, 2025
92d648e
fixup comments
picnixz Mar 30, 2025
25c2a3f
Merge branch 'main' into fix/ubsan/casts-111178
picnixz Mar 31, 2025
4bf2a1e
Update Modules/faulthandler.c
picnixz Apr 1, 2025
db5dae1
Update Include/cpython/object.h
picnixz Apr 1, 2025
6cfed6c
Update Python/ceval.c
picnixz Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: _PyDictViewObject
  • Loading branch information
@picnixz
picnixz committed Mar 24, 2025
commit 2fea60f8a7dfafe3b37fcc0bd838fad0c71b48cd
10 changes: 5 additions & 5 deletions Objects/dictobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6339,7 +6339,7 @@ dictviews_xor(PyObject* self, PyObject *other)

static PyNumberMethods dictviews_as_number = {
0, /*nb_add*/
(binaryfunc)dictviews_sub, /*nb_subtract*/
dictviews_sub, /*nb_subtract*/
0, /*nb_multiply*/
0, /*nb_remainder*/
0, /*nb_divmod*/
Expand All @@ -6351,9 +6351,9 @@ static PyNumberMethods dictviews_as_number = {
0, /*nb_invert*/
0, /*nb_lshift*/
0, /*nb_rshift*/
(binaryfunc)_PyDictView_Intersect, /*nb_and*/
(binaryfunc)dictviews_xor, /*nb_xor*/
(binaryfunc)dictviews_or, /*nb_or*/
_PyDictView_Intersect, /*nb_and*/
dictviews_xor, /*nb_xor*/
dictviews_or, /*nb_or*/
};

static PyObject*
Expand Down Expand Up @@ -6611,7 +6611,7 @@ static PySequenceMethods dictvalues_as_sequence = {
0, /* sq_slice */
0, /* sq_ass_item */
0, /* sq_ass_slice */
(objobjproc)0, /* sq_contains */
0, /* sq_contains */
};

static PyObject* dictvalues_reversed(PyObject *dv, PyObject *Py_UNUSED(ignored));
Expand Down