Skip to content

gh-132097: remove unnecessary clinic casts to PyCFunction and others #131665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
picnixz wants to merge 12 commits into from
Closed

gh-132097: remove unnecessary clinic casts to PyCFunction and others #131665

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
074b2ae
do not add a PyCFunction cast for METH_NOARGS, METH_O and METH_VARARGS
picnixz Mar 24, 2025
65b14c1
update clinic hard-coded tests
picnixz Mar 24, 2025
4e2153a
update autogenerated content
picnixz Mar 24, 2025
502f5cb
Merge remote-tracking branch 'upstream/main' into fix/ubsan/ac-redund…
picnixz Apr 3, 2025
857e476
remove auto-genmerated getter/setter casts
picnixz Apr 3, 2025
f1b1dc9
sync
picnixz Apr 3, 2025
24a02bc
Merge remote-tracking branch 'upstream/main' into fix/ubsan/ac-redund…
picnixz Apr 4, 2025
44b7246
Merge remote-tracking branch 'upstream/main' into fix/ubsan/ac-redund…
picnixz Apr 5, 2025
8d2fb6d
clinic
picnixz Apr 5, 2025
af0ee39
clinic
picnixz Apr 5, 2025
1f20b58
Merge remote-tracking branch 'upstream/main' into fix/ubsan/ac-redund…
picnixz Apr 16, 2025
21b3667
Merge remote-tracking branch 'upstream/main' into fix/ubsan/ac-redund…
picnixz Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
sync
  • Loading branch information
@picnixz
picnixz committed Apr 3, 2025
commit f1b1dc92ab1da045d2fa48432bb82294889ed767
24 changes: 12 additions & 12 deletions Lib/test/clinic.test.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5364,9 +5364,9 @@ Test.property
#endif
#if defined(TEST_PROPERTY_GETSETDEF)
# undef TEST_PROPERTY_GETSETDEF
# define TEST_PROPERTY_GETSETDEF {"property", (getter)Test_property_get, (setter)Test_property_set, Test_property_DOCSTR},
# define TEST_PROPERTY_GETSETDEF {"property", Test_property_get, Test_property_set, Test_property_DOCSTR},
#else
# define TEST_PROPERTY_GETSETDEF {"property", (getter)Test_property_get, NULL, Test_property_DOCSTR},
# define TEST_PROPERTY_GETSETDEF {"property", Test_property_get, NULL, Test_property_DOCSTR},
#endif

static PyObject *
Expand All @@ -5380,7 +5380,7 @@ Test_property_get(PyObject *self, void *Py_UNUSED(context))

static PyObject *
Test_property_get_impl(TestObj *self)
/*[clinic end generated code: output=b38d68abd3466a6e input=2d92b3449fbc7d2b]*/
/*[clinic end generated code: output=4d600bc77ca96957 input=2d92b3449fbc7d2b]*/

/*[clinic input]
@setter
Expand All @@ -5392,9 +5392,9 @@ Test.property
#endif
#if defined(TEST_PROPERTY_GETSETDEF)
# undef TEST_PROPERTY_GETSETDEF
# define TEST_PROPERTY_GETSETDEF {"property", (getter)Test_property_get, (setter)Test_property_set, Test_property_DOCSTR},
# define TEST_PROPERTY_GETSETDEF {"property", Test_property_get, Test_property_set, Test_property_DOCSTR},
#else
# define TEST_PROPERTY_GETSETDEF {"property", NULL, (setter)Test_property_set, NULL},
# define TEST_PROPERTY_GETSETDEF {"property", NULL, Test_property_set, NULL},
#endif

static int
Expand All @@ -5412,7 +5412,7 @@ Test_property_set(PyObject *self, PyObject *value, void *Py_UNUSED(context))

static int
Test_property_set_impl(TestObj *self, PyObject *value)
/*[clinic end generated code: output=49f925ab2a33b637 input=3bc3f46a23c83a88]*/
/*[clinic end generated code: output=5d1024e9700a89dd input=3bc3f46a23c83a88]*/

/*[clinic input]
@setter
Expand All @@ -5424,9 +5424,9 @@ Test.setter_first_with_docstr
#endif
#if defined(TEST_SETTER_FIRST_WITH_DOCSTR_GETSETDEF)
# undef TEST_SETTER_FIRST_WITH_DOCSTR_GETSETDEF
# define TEST_SETTER_FIRST_WITH_DOCSTR_GETSETDEF {"setter_first_with_docstr", (getter)Test_setter_first_with_docstr_get, (setter)Test_setter_first_with_docstr_set, Test_setter_first_with_docstr_DOCSTR},
# define TEST_SETTER_FIRST_WITH_DOCSTR_GETSETDEF {"setter_first_with_docstr", Test_setter_first_with_docstr_get, Test_setter_first_with_docstr_set, Test_setter_first_with_docstr_DOCSTR},
#else
# define TEST_SETTER_FIRST_WITH_DOCSTR_GETSETDEF {"setter_first_with_docstr", NULL, (setter)Test_setter_first_with_docstr_set, NULL},
# define TEST_SETTER_FIRST_WITH_DOCSTR_GETSETDEF {"setter_first_with_docstr", NULL, Test_setter_first_with_docstr_set, NULL},
#endif

static int
Expand All @@ -5444,7 +5444,7 @@ Test_setter_first_with_docstr_set(PyObject *self, PyObject *value, void *Py_UNUS

static int
Test_setter_first_with_docstr_set_impl(TestObj *self, PyObject *value)
/*[clinic end generated code: output=5aaf44373c0af545 input=31a045ce11bbe961]*/
/*[clinic end generated code: output=b3e243759a22bb02 input=31a045ce11bbe961]*/

/*[clinic input]
@getter
Expand All @@ -5465,9 +5465,9 @@ PyDoc_STRVAR(Test_setter_first_with_docstr__doc__,
#endif
#if defined(TEST_SETTER_FIRST_WITH_DOCSTR_GETSETDEF)
# undef TEST_SETTER_FIRST_WITH_DOCSTR_GETSETDEF
# define TEST_SETTER_FIRST_WITH_DOCSTR_GETSETDEF {"setter_first_with_docstr", (getter)Test_setter_first_with_docstr_get, (setter)Test_setter_first_with_docstr_set, Test_setter_first_with_docstr_DOCSTR},
# define TEST_SETTER_FIRST_WITH_DOCSTR_GETSETDEF {"setter_first_with_docstr", Test_setter_first_with_docstr_get, Test_setter_first_with_docstr_set, Test_setter_first_with_docstr_DOCSTR},
#else
# define TEST_SETTER_FIRST_WITH_DOCSTR_GETSETDEF {"setter_first_with_docstr", (getter)Test_setter_first_with_docstr_get, NULL, Test_setter_first_with_docstr_DOCSTR},
# define TEST_SETTER_FIRST_WITH_DOCSTR_GETSETDEF {"setter_first_with_docstr", Test_setter_first_with_docstr_get, NULL, Test_setter_first_with_docstr_DOCSTR},
#endif

static PyObject *
Expand All @@ -5481,7 +5481,7 @@ Test_setter_first_with_docstr_get(PyObject *self, void *Py_UNUSED(context))

static PyObject *
Test_setter_first_with_docstr_get_impl(TestObj *self)
/*[clinic end generated code: output=fe6e3aa844a24920 input=10af4e43b3cb34dc]*/
/*[clinic end generated code: output=968a7642c38ef6e6 input=10af4e43b3cb34dc]*/

/*[clinic input]
output push
Expand Down