Skip to content

[3.13] gh-131357: Add a set of asserts to test.test_capi.test_bytearray (GH-131554) #131601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sobolevn merged 1 commit into from
Mar 23, 2025
+5 −2
Merged

[3.13] gh-131357: Add a set of asserts to test.test_capi.test_bytearray (GH-131554) #131601

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
gh-131357: Add a set of asserts to test.test_capi.test_bytearray (GH-… 
…131554)

add a set of asserts to test.test_capi.test_bytearray

1. Assert empty bytearray object for PyByteArray_Check.
2. Assert empty bytearray object for PyByteArray_CheckExact.
3. Assert 0-size bytearray object for PyByteArray_Size.
4. Assert empty bytearray object for PyByteArray_AsString.
5. Assert concatenation of the bytearray object with itself for PyByteArray_Concat.
(cherry picked from commit f3bf304)

Co-authored-by: Nybblista <170842536+nybblista@users.noreply.github.com>
  • Loading branch information
@nybblista @miss-islington
nybblista authored and miss-islington committed Mar 23, 2025
commit 9b6ea9b6a1a0608a613817bbb28ff4d89b7e8024
7 changes: 5 additions & 2 deletions Lib/test/test_capi/test_bytearray.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ class CAPITest(unittest.TestCase):
def test_check(self):
# Test PyByteArray_Check()
check = _testlimitedcapi.bytearray_check
self.assertTrue(check(bytearray(b'')))
self.assertTrue(check(bytearray(b'abc')))
self.assertFalse(check(b'abc'))
self.assertTrue(check(ByteArraySubclass(b'abc')))
Expand All @@ -33,6 +34,7 @@ def test_check(self):
def test_checkexact(self):
# Test PyByteArray_CheckExact()
check = _testlimitedcapi.bytearray_checkexact
self.assertTrue(check(bytearray(b'')))
self.assertTrue(check(bytearray(b'abc')))
self.assertFalse(check(b'abc'))
self.assertFalse(check(ByteArraySubclass(b'abc')))
Expand Down Expand Up @@ -78,7 +80,7 @@ def test_fromobject(self):
def test_size(self):
# Test PyByteArray_Size()
size = _testlimitedcapi.bytearray_size

self.assertEqual(size(bytearray(b'')), 0)
self.assertEqual(size(bytearray(b'abc')), 3)
self.assertEqual(size(ByteArraySubclass(b'abc')), 3)

Expand All @@ -89,7 +91,7 @@ def test_size(self):
def test_asstring(self):
"""Test PyByteArray_AsString()"""
asstring = _testlimitedcapi.bytearray_asstring

self.assertEqual(asstring(bytearray(b''), 1), b'\0')
self.assertEqual(asstring(bytearray(b'abc'), 4), b'abc\0')
self.assertEqual(asstring(ByteArraySubclass(b'abc'), 4), b'abc\0')
self.assertEqual(asstring(bytearray(b'abc\0def'), 8), b'abc\0def\0')
Expand All @@ -105,6 +107,7 @@ def test_concat(self):
ba = bytearray(b'abc')
self.assertEqual(concat(ba, b'def'), bytearray(b'abcdef'))
self.assertEqual(ba, b'abc')
self.assertEqual(concat(ba, ba), bytearray(b'abcabc'))

self.assertEqual(concat(b'abc', b'def'), bytearray(b'abcdef'))
self.assertEqual(concat(b'a\0b', b'c\0d'), bytearray(b'a\0bc\0d'))
Expand Down