Skip to content

bpo-36822: Fix minor grammatical error in glossary.rst#13145

Merged
pablogsal merged 1 commit into
python:masterfrom
CuriousLearner:minor-grammar-fix
May 11, 2019
Merged

bpo-36822: Fix minor grammatical error in glossary.rst#13145
pablogsal merged 1 commit into
python:masterfrom
CuriousLearner:minor-grammar-fix

Conversation

@CuriousLearner
Copy link
Copy Markdown
Member

@CuriousLearner CuriousLearner commented May 6, 2019 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 6, 2019
@CuriousLearner
Copy link
Copy Markdown
Member Author

CuriousLearner commented May 11, 2019

Hey @pablogsal

Can you please take a look at this?

pablogsal
pablogsal approved these changes May 11, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablogsal pablogsal merged commit 90fb04c into python:master May 11, 2019
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented May 11, 2019

Thanks @CuriousLearner for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@pablogsal
Copy link
Copy Markdown
Member

pablogsal commented May 11, 2019

Thanks for the fix @CuriousLearner 🎉

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented May 11, 2019

Sorry, @CuriousLearner and @pablogsal, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 90fb04c1e23c0fddd438bd0f73e7c018cacef4bc 3.7

@pablogsal
Copy link
Copy Markdown
Member

pablogsal commented May 11, 2019

@CuriousLearner Could yo do the backport manually (if is needed)?

CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request May 12, 2019
@CuriousLearner
[3.7] bpo-36822: Fix minor grammatical error in glossary.rst (pythonG…
7e74697 
…H-13145).

(cherry picked from commit 90fb04c)

Co-authored-by: Sanyam Khurana <8039608+CuriousLearner@users.noreply.github.com>
@CuriousLearner CuriousLearner mentioned this pull request May 12, 2019
Merged
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented May 12, 2019

GH-13260 is a backport of this pull request to the 3.7 branch.

@CuriousLearner
Copy link
Copy Markdown
Member Author

CuriousLearner commented May 12, 2019

Hey @pablogsal

Here it is: #13260

pablogsal pushed a commit that referenced this pull request May 12, 2019
@CuriousLearner @pablogsal
[3.7] bpo-36822: Fix minor grammatical error in glossary.rst (GH-13145)…
4f5febd 
…. (GH-13260)

(cherry picked from commit 90fb04c)

Co-authored-by: Sanyam Khurana <8039608+CuriousLearner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Assignees

@pablogsal pablogsal

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@CuriousLearner @miss-islington @pablogsal @bedevere-bot @the-knights-who-say-ni