Skip to content

gh-123471: Make concurrent iteration over itertools.cycle safe under free-threading #131212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumaraditya303 merged 10 commits into from
Jun 2, 2025
+46 −14
Merged

gh-123471: Make concurrent iteration over itertools.cycle safe under free-threading #131212

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9e5cb51
remove dead code related to firstpass
eendebakpt Mar 13, 2025
62bf9c2
make cycle_next thread safe
eendebakpt Mar 13, 2025
c7f6ba0
📜🤖 Added by blurb_it.
blurb-it[bot] Mar 13, 2025
dea1835
fix index update
eendebakpt Mar 13, 2025
204bbe8
Merge branch 'cycle_ft' of github.com:eendebakpt/cpython into cycle_ft
eendebakpt Mar 13, 2025
5d2891c
Merge branch 'main' into cycle_ft
eendebakpt Mar 23, 2025
0e38748
Merge branch 'main' into cycle_ft
eendebakpt Apr 22, 2025
9730fba
Merge branch 'main' into cycle_ft
kumaraditya303 May 28, 2025
ab442da
use PyList_GetItemRef
eendebakpt May 28, 2025
c9d991a
Merge branch 'main' into cycle_ft
eendebakpt May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use PyList_GetItemRef
  • Loading branch information
@eendebakpt
eendebakpt committed May 28, 2025
commit ab442da8ecac1dc16812c1f1425d5dfce36bcf24
5 changes: 3 additions & 2 deletions Modules/itertoolsmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1219,13 +1219,14 @@ cycle_next(PyObject *op)
}
if (PyList_GET_SIZE(lz->saved) == 0)
return NULL;
item = PyList_GET_ITEM(lz->saved, index);
item = PyList_GetItemRef(lz->saved, index);
assert(item);
index++;
if (index >= PyList_GET_SIZE(lz->saved)) {
index = 0;
}
FT_ATOMIC_STORE_SSIZE_RELAXED(lz->index, index);
return Py_NewRef(item);
return item;
}

static PyType_Slot cycle_slots[] = {
Expand Down
Loading