Skip to content

gh-131050: Allow CPython test to handle TLS libraries lacking FFDHE ciphersuites #131051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
picnixz merged 11 commits into from
Mar 29, 2025
Merged

gh-131050: Allow CPython test to handle TLS libraries lacking FFDHE ciphersuites #131051

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
80e7fd8
Detect DHE support in test_ssl.py test
WillChilds-Klein Mar 10, 2025
61b1a11
📜🤖 Added by blurb_it.
blurb-it[bot] Mar 10, 2025
f3de8b1
Fix news blurb lint errors
WillChilds-Klein Mar 10, 2025
d4121d7
Adjust skipTest message, add back DHFILE load
WillChilds-Klein Mar 10, 2025
e3704ca
Implement PR feedback
WillChilds-Klein Mar 13, 2025
73146a8
Update Misc/NEWS.d/next/Tests/2025-03-10-18-58-03.gh-issue-131050.FMB…
WillChilds-Klein Mar 13, 2025
9bf7e6c
Revert parts to a list
WillChilds-Klein Mar 13, 2025
781d531
Merge branch 'main' into detect-dhe-support
WillChilds-Klein Mar 19, 2025
57317e2
Merge branch 'main' into detect-dhe-support
WillChilds-Klein Mar 28, 2025
7a8375a
Extract supports_kx_aliases test util
WillChilds-Klein Mar 28, 2025
569cf55
Update Lib/test/test_ssl.py
picnixz Mar 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix news blurb lint errors
  • Loading branch information
@WillChilds-Klein
WillChilds-Klein committed Mar 10, 2025
commit f3de8b166c1ce2a81df53dc9d8ae12687f0063cf
2 changes: 1 addition & 1 deletion Misc/NEWS.d/next/Tests/2025-03-10-18-58-03.gh-issue-131050.FMBAPN.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Some cryptography TLS libraries lack support for "finite field" ephemeral Diffie-Hellman (FFDHE) TLS ciphersuites. This issue proposes modifying `test_ssl`'s `test_dh_params` to skip itself if the underlying TLS library does not support FFDHE.
Some cryptography TLS libraries lack support for "finite field" ephemeral Diffie-Hellman (FFDHE) TLS ciphersuites. This issue proposes modifying ``test_ssl``'s ``test_dh_params`` to skip itself if the underlying TLS library does not support FFDHE.
Comment thread
WillChilds-Klein marked this conversation as resolved.
Outdated