Skip to content

gh-111178: fix UBSan failures in Modules/posixmodule.c #129788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encukou merged 8 commits into from
Feb 24, 2025
+31 −20
Merged

gh-111178: fix UBSan failures in Modules/posixmodule.c #129788

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f53e72a
fix UBSan failures for `DirEntry`
picnixz Feb 6, 2025
b09c08b
fix UBSan failures for `ScandirIterator`
picnixz Feb 6, 2025
fae1434
use 'ignored' for NOARGS method and 'args' for others
picnixz Feb 6, 2025
b071d12
Merge remote-tracking branch 'upstream/main' into fix/ubsan/posix-111178
picnixz Feb 7, 2025
d6e9148
address Petr's review
picnixz Feb 22, 2025
fe5a983
use better semantic namgin
picnixz Feb 22, 2025
84aef29
remove redundant cast
picnixz Feb 22, 2025
442d0ba
Merge branch 'main' into fix/ubsan/posix-111178
picnixz Feb 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix UBSan failures for DirEntry
  • Loading branch information
@picnixz
picnixz committed Feb 6, 2025
commit f53e72ac5e38fb3eb70b47a123194bef03d3ef6d
8 changes: 6 additions & 2 deletions Modules/posixmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15523,9 +15523,12 @@ typedef struct {
#endif
} DirEntry;

#define DirEntry_CAST(op) ((DirEntry *)(op))

static void
DirEntry_dealloc(DirEntry *entry)
DirEntry_dealloc(PyObject *op)
{
DirEntry *entry = DirEntry_CAST(op);
PyTypeObject *tp = Py_TYPE(entry);
Py_XDECREF(entry->name);
Py_XDECREF(entry->path);
Expand Down Expand Up @@ -15854,8 +15857,9 @@ os_DirEntry_inode_impl(DirEntry *self)
}

static PyObject *
DirEntry_repr(DirEntry *self)
DirEntry_repr(PyObject *op)
{
DirEntry *self = DirEntry_CAST(op);
return PyUnicode_FromFormat("<DirEntry %R>", self->name);
}

Expand Down