Skip to content

gh-111178: fix UBSan failures in Modules/_functoolsmodule.c #129778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encukou merged 6 commits into from
Feb 21, 2025
Merged

gh-111178: fix UBSan failures in Modules/_functoolsmodule.c #129778

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
838630d
fix UBSan failures for `keyobject`
picnixz Jan 25, 2025
7b9170d
fix UBSan failures for `lru_list_elem`
picnixz Jan 25, 2025
c27a965
fix UBSan failures for `lru_cache_object`
picnixz Jan 25, 2025
810ecce
suppress unused return values
picnixz Jan 25, 2025
20069b8
Merge remote-tracking branch 'upstream/main' into fix/ubsan/functools…
picnixz Feb 7, 2025
fcc20f4
Do not add an underscore to the macro if none is needed.
picnixz Feb 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix UBSan failures for lru_list_elem
  • Loading branch information
@picnixz
picnixz committed Jan 25, 2025
commit 7b9170da49c7bdc888f8675c3484c8672796b3fe
5 changes: 4 additions & 1 deletion Modules/_functoolsmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1061,9 +1061,12 @@ typedef struct lru_list_elem {
PyObject *key, *result;
} lru_list_elem;

#define _lru_list_elem_CAST(op) ((lru_list_elem *)(op))

static void
lru_list_elem_dealloc(lru_list_elem *link)
lru_list_elem_dealloc(PyObject *op)
{
lru_list_elem *link = _lru_list_elem_CAST(op);
PyTypeObject *tp = Py_TYPE(link);
Py_XDECREF(link->key);
Py_XDECREF(link->result);
Expand Down