Skip to content

bpo-36722: Don't define ALT_SOABI for Py_TRACE_REFS build#12973

Merged
vstinner merged 1 commit intopython:masterfrom
vstinner:fix_trace_refs_soabi
Apr 26, 2019
Merged

bpo-36722: Don't define ALT_SOABI for Py_TRACE_REFS build#12973
vstinner merged 1 commit intopython:masterfrom
vstinner:fix_trace_refs_soabi

Conversation

@vstinner
Copy link
Copy Markdown
Member

@vstinner vstinner commented Apr 26, 2019 •
edited by bedevere-bot
Loading

Py_TRACE_REFS ABI is incompatible with release and debug (Py_DEBUG)
ABI.

https://bugs.python.org/issue36722

@vstinner
bpo-36722: Don't define ALT_SOABI for Py_TRACE_REFS build
3abc2e5 
Py_TRACE_REFS ABI is incompatible with release and debug (Py_DEBUG)
ABI.
@vstinner
Copy link
Copy Markdown
Member Author

vstinner commented Apr 26, 2019

I checked manually pyconfig.h in these 3 configurations. It now works as expected. Moreover, pyport.h ensures that ALT_SOABI is not defined when Py_TRACE_REFS is defined, just in case.

./configure:

/* #undef ALT_SOABI */
/* #undef Py_DEBUG */
/* #undef Py_TRACE_REFS */

./configure --with-pydebug:

#define ALT_SOABI "cpython-38-x86_64-linux-gnu"
#define Py_DEBUG 1
/* #undef Py_TRACE_REFS */

./configure --with-trace-refs:

/* #undef ALT_SOABI */
/* #undef Py_DEBUG */
#define Py_TRACE_REFS 1

ALT_SOABI is only defined when Py_DEBUG is defined, but not when Py_TRACE_REFS is defined: as expected.

@vstinner vstinner merged commit 6d13e5b into python:master Apr 26, 2019
@vstinner vstinner deleted the fix_trace_refs_soabi branch April 26, 2019 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @the-knights-who-say-ni @bedevere-bot