Skip to content

Convert change detection to a Python script #129627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AA-Turner merged 14 commits into from
Feb 5, 2025
Merged

Convert change detection to a Python script #129627

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
819da3b
Convert change detection to a Python script
AA-Turner Feb 3, 2025
4c0a7a4
Hugo's review
AA-Turner Feb 4, 2025
4169b46
Simplify
AA-Turner Feb 4, 2025
49f02be
Standardise workflow variables:
AA-Turner Feb 4, 2025
d65e5be
no # bool
AA-Turner Feb 5, 2025
b40113e
Add step name
AA-Turner Feb 5, 2025
1ee4e0e
empty
AA-Turner Feb 5, 2025
e183b15
Merge run_hypothesis into run_tests
AA-Turner Feb 5, 2025
e03d295
Use github.event.repository.default_branch per review
AA-Turner Feb 5, 2025
05253e3
Update Tools/build/compute-changes.py
AA-Turner Feb 5, 2025
f45c009
fix syntax error in suggestion
AA-Turner Feb 5, 2025
e265fa5
Rename to "context" from "change-detection"
AA-Turner Feb 5, 2025
06ef117
fixup! Rename to "context" from "change-detection"
AA-Turner Feb 5, 2025
f52c88f
fixup! Rename to "context" from "change-detection"
AA-Turner Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Simplify
  • Loading branch information
@AA-Turner
AA-Turner committed Feb 4, 2025
commit 4169b462b0701d718c5f3e521454a12c42281934
22 changes: 9 additions & 13 deletions Tools/build/compute-changes.py
View file
Open in desktop
Comment thread
AA-Turner marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -102,34 +102,30 @@ def process_changed_files(changed_files: Set[Path]) -> Outputs:
run_windows_msi = False

for file in changed_files:
file_name = file.name
file_suffix = file.suffix
file_parts = file.parts

# Documentation files
doc_or_misc = file_parts[0] in {"Doc", "Misc"}
doc_file = file_suffix in SUFFIXES_DOCUMENTATION or doc_or_misc
doc_or_misc = file.parts[0] in {"Doc", "Misc"}
doc_file = file.suffix in SUFFIXES_DOCUMENTATION or doc_or_misc

if file.parent == GITHUB_WORKFLOWS_PATH:
if file_name == "build.yml":
if file.name == "build.yml":
Comment thread
AA-Turner marked this conversation as resolved.
run_tests = run_ci_fuzz = True
if file_name == "reusable-docs.yml":
if file.name == "reusable-docs.yml":
run_docs = True
if file_name == "reusable-windows-msi.yml":
if file.name == "reusable-windows-msi.yml":
run_windows_msi = True

if not (
doc_file
or file == GITHUB_CODEOWNERS_PATH
or file_name in CONFIGURATION_FILE_NAMES
or file.name in CONFIGURATION_FILE_NAMES
):
run_tests = True

# The fuzz tests are pretty slow so they are executed only for PRs
# changing relevant files.
if file_suffix in SUFFIXES_C_OR_CPP:
if file.suffix in SUFFIXES_C_OR_CPP:
run_ci_fuzz = True
if file_parts[:2] in {
if file.parts[:2] in {
("configure",),
("Modules", "_xxtestfuzz"),
}:
Expand All @@ -140,7 +136,7 @@ def process_changed_files(changed_files: Set[Path]) -> Outputs:
run_docs = True

# Check for changed MSI installer-related files
if file_parts[:2] == ("Tools", "msi"):
if file.parts[:2] == ("Tools", "msi"):
run_windows_msi = True

return Outputs(
Expand Down