address review: fix typo in news & gamma/lgamma error messages

python · vstinner · Apr 22, 2025 · Jan 31, 2025 · Jan 31, 2025 · Feb 4, 2025
commit 53b68c2f05d55982efacce2fb83efd99e7356495
diff --git a/Lib/test/test_math.py b/Lib/test/test_math.py
@@ -2536,7 +2536,7 @@ def test_exception_messages(self):
                                     "expected a positive input"):
             math.log(x)
         with self.assertRaisesRegex(ValueError,
-                                    f"expected a float or positive integer, got {x}"):
+                                    f"expected a noninteger or positive integer, got {x}"):
             math.gamma(x)
         x = 1.0
         with self.assertRaisesRegex(ValueError,

diff --git a/Misc/NEWS.d/next/Library/2023-02-01-16-41-31.gh-issue-101410.Dt2aQE.rst b/Misc/NEWS.d/next/Library/2023-02-01-16-41-31.gh-issue-101410.Dt2aQE.rst
@@ -1,3 +1,2 @@
 Added more detailed messages for domain errors in the :mod:`math` module.
 Patch by Charlie Zhao and Sergey B Kirpichev.
-Patch by Charlie Zhao and Sergey B Kirpichev.
diff --git a/Modules/mathmodule.c b/Modules/mathmodule.c
@@ -1232,11 +1232,11 @@ math_floor(PyObject *module, PyObject *number)
 FUNC1AD(gamma, m_tgamma,
       "gamma($module, x, /)\n--\n\n"
       "Gamma function at x.",
-      "expected a float or positive integer, got %s")
+      "expected a noninteger or positive integer, got %s")
 FUNC1AD(lgamma, m_lgamma,
       "lgamma($module, x, /)\n--\n\n"
       "Natural logarithm of absolute value of Gamma function at x.",
-      "expected a float or positive integer, got %s")
+      "expected a noninteger or positive integer, got %s")
 FUNC1D(log1p, m_log1p, 0,
       "log1p($module, x, /)\n--\n\n"
       "Return the natural logarithm of 1+x (base e).\n\n"