Skip to content

gh-128588: gh-128550: remove eager tasks optimization that missed and introduced incorrect cancellations #129063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumaraditya303 merged 7 commits into from
Jan 20, 2025
Merged

gh-128588: gh-128550: remove eager tasks optimization that missed and introduced incorrect cancellations #129063

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9fce599
gh-128588: gh-128550: remove eager tasks optimization that missed and…
graingert Jan 20, 2025
73042cf
📜🤖 Added by blurb_it.
blurb-it[bot] Jan 20, 2025
867bacb
Update Lib/test/test_asyncio/test_taskgroups.py
graingert Jan 20, 2025
c460fa9
Update Lib/test/test_asyncio/test_taskgroups.py
graingert Jan 20, 2025
187abc7
Update Misc/NEWS.d/next/Library/2025-01-20-13-12-39.gh-issue-128550.A…
graingert Jan 20, 2025
874f758
Update Lib/test/test_asyncio/test_taskgroups.py
kumaraditya303 Jan 20, 2025
74ef5cc
Update Misc/NEWS.d/next/Library/2025-01-20-13-12-39.gh-issue-128550.A…
kumaraditya303 Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Lib/test/test_asyncio/test_taskgroups.py
  • Loading branch information
@graingert
graingert authored Jan 20, 2025
commit c460fa9e45217dbf2efec8295d4dc9065663f41d
4 changes: 4 additions & 0 deletions Lib/test/test_asyncio/test_taskgroups.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1084,6 +1084,10 @@ async def throw_error():
else:
self.fail("should have raised one MyError in group")

# if this test fails this current task will be cancelled
# outside the TG and inside unittest internals
# we add somewhere to cancel here so the test failure message
# is more understandable
Comment thread
kumaraditya303 marked this conversation as resolved.
Outdated
await asyncio.sleep(0)
Comment thread
graingert marked this conversation as resolved.


Expand Down