Skip to content

gh-89745: Remove dead realpath branch in getpath.c #128861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pelson wants to merge 1 commit into from
Closed

gh-89745: Remove dead realpath branch in getpath.c #128861

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Remove realpath branch in getpath - the readlink code before is alway… 
…s taking precedence
  • Loading branch information
@pelson
pelson committed Jan 15, 2025
commit b30c594d5c74daf4707ba64157bee92593148151
31 changes: 0 additions & 31 deletions Modules/getpath.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,37 +478,6 @@ getpath_realpath(PyObject *Py_UNUSED(self) , PyObject *args)
PyMem_RawFree((void *)path);
return r;

#elif defined(HAVE_REALPATH)
PyObject *r = NULL;
struct stat st;
const char *narrow = NULL;
wchar_t *path = PyUnicode_AsWideCharString(pathobj, NULL);
if (!path) {
goto done;
}
narrow = Py_EncodeLocale(path, NULL);
if (!narrow) {
PyErr_NoMemory();
goto done;
}
if (lstat(narrow, &st)) {
PyErr_SetFromErrno(PyExc_OSError);
goto done;
}
if (!S_ISLNK(st.st_mode)) {
r = Py_NewRef(pathobj);
goto done;
}
wchar_t resolved[MAXPATHLEN+1];
if (_Py_wrealpath(path, resolved, MAXPATHLEN) == NULL) {
PyErr_SetFromErrno(PyExc_OSError);
} else {
r = PyUnicode_FromWideChar(resolved, -1);
}
done:
PyMem_Free((void *)path);
PyMem_Free((void *)narrow);
return r;
#elif defined(MS_WINDOWS)
HANDLE hFile;
wchar_t resolved[MAXPATHLEN+1];
Expand Down