gh-128720: Fix doc inacurracy about __main__.__file__ existence in the REPL - #128721
Merged
Conversation
AA-Turner
approved these changes
Jan 11, 2025
Comment on lines
-364
to
-366
| Note that in this case the ``__main__`` scope doesn't contain a ``__file__`` | ||
| attribute as it's interactive. | ||
|
|
Member
There was a problem hiding this comment.
We may want to keep this line, depending on the resolution of the issue. I agree with the changes above.
pablogsal
approved these changes
Jan 21, 2025
Member
|
Thanks a lot for the contribution @wimglenn and @AA-Turner for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I opted to just remove the confusing conditional.
If the example needs a "check for REPL" conditional, I'd suggest checking
sys.ps1, however I think that could be scope creep and the example script is better off without that condition at all.📚 Documentation preview 📚: https://cpython-previews--128721.org.readthedocs.build/