Skip to content

gh-127146: Strip dash from Emscripten compiler version #128557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
freakboy3742 merged 1 commit into from
Jan 6, 2025
Merged

gh-127146: Strip dash from Emscripten compiler version #128557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
gh-127146: Strip dash from Emscripten compiler version 
`emcc -dumpversion` will sometimes say e.g., `4.0.0-git` but in this case
uname does not include `-git` in the version string. Use cut to delete
everything after the dash.
  • Loading branch information
@hoodmane
hoodmane committed Jan 6, 2025
commit 272ad5c28d8b6b7e82119eac4e73b39d7ca6d7b9
2 changes: 1 addition & 1 deletion configure
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -794,7 +794,7 @@ if test "$cross_compiling" = yes; then
_host_ident=$host_cpu
;;
*-*-emscripten)
_host_ident=$(emcc -dumpversion)-$host_cpu
_host_ident=$(emcc -dumpversion | cut -f1 -d-)-$host_cpu
;;
wasm32-*-* | wasm64-*-*)
_host_ident=$host_cpu
Expand Down