Skip to content

gh-128552: fix refcycles in eager task creation #128553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumaraditya303 merged 13 commits into from
Jan 7, 2025
Merged

gh-128552: fix refcycles in eager task creation #128553

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
c82f30b
gh-128552: fix refcycles in eager task creation
graingert Jan 6, 2025
8a4eb56
Update Lib/asyncio/base_events.py
graingert Jan 6, 2025
35a38e4
Update Lib/asyncio/taskgroups.py
graingert Jan 6, 2025
afd3053
📜🤖 Added by blurb_it.
blurb-it[bot] Jan 6, 2025
9700ebf
Rename 2025-01-06-18-41-08.gh-issue-gh-128552.fV-f8j.rst to 2025-01-0…
graingert Jan 6, 2025
fe83add
Update Misc/NEWS.d/next/Library/2025-01-06-18-41-08.gh-issue-128552.f…
graingert Jan 6, 2025
a1f76df
Merge branch 'main' into fix-taskgroup-eager-refcycle
graingert Jan 6, 2025
7c966d0
add a version of the test with weakrefs
graingert Jan 7, 2025
89362f5
Merge branch 'main' into fix-taskgroup-eager-refcycle
graingert Jan 7, 2025
cf5cfe3
simplify and comment
graingert Jan 7, 2025
18b6ea9
Update Lib/asyncio/base_events.py
graingert Jan 7, 2025
ca71935
restore _set_event_loop_policy(None)
graingert Jan 7, 2025
cc39717
remove type annotations
graingert Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove type annotations
  • Loading branch information
@graingert
graingert authored Jan 7, 2025
commit cc39717345e7af1c9f38dc3a16e919ef9764afd6
4 changes: 2 additions & 2 deletions Lib/test/test_asyncio/test_taskgroups.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def no_other_refs():
return [coro]


def set_gc_state(enabled: bool) -> bool:
def set_gc_state(enabled):
was_enabled = gc.isenabled()
if enabled:
gc.enable()
Expand All @@ -49,7 +49,7 @@ def set_gc_state(enabled: bool) -> bool:


@contextlib.contextmanager
def disable_gc() -> Generator[None]:
def disable_gc():
was_enabled = set_gc_state(enabled=False)
try:
yield
Expand Down